Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: webrtc/api/audio_codecs/audio_format.h

Issue 2831333002: Allow a received audio codec's payload type to change. (Closed)
Patch Set: Simplifying code, adding comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/audio_codecs/audio_format.cc » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/audio_codecs/audio_format.h
diff --git a/webrtc/api/audio_codecs/audio_format.h b/webrtc/api/audio_codecs/audio_format.h
index 8814a3dcdcc0c700424f7990c1c6d8b0261c08ae..4bdb924727a4267c83964045242898315620cdab 100644
--- a/webrtc/api/audio_codecs/audio_format.h
+++ b/webrtc/api/audio_codecs/audio_format.h
@@ -41,6 +41,11 @@ struct SdpAudioFormat {
const Parameters& param);
~SdpAudioFormat();
+ // Returns true if this format is compatible with |o|. In SDP terminology,
the sun 2017/04/26 07:44:10 super nit: end in ":", not "," oh well... :)
Taylor Brandstetter 2017/04/26 23:04:40 Done.
+ // would it represent the same codec between an offer and an answer? As
+ // opposed to operator==, this method disregards codec parameters.
+ bool Matches(const SdpAudioFormat& o) const;
the sun 2017/04/26 07:44:09 More importantly though, can we deprecate operator
Taylor Brandstetter 2017/04/26 23:04:40 It has some existing uses (decoder_database.cc and
+
SdpAudioFormat& operator=(const SdpAudioFormat&);
SdpAudioFormat& operator=(SdpAudioFormat&&);
« no previous file with comments | « no previous file | webrtc/api/audio_codecs/audio_format.cc » ('j') | webrtc/media/engine/webrtcvoiceengine.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698