webrtc/sdk/BUILD.gn - Issue 2828793003: GN: Tighten up test target visibility + refactorings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)

Patch Set: Disable Win compile warning Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/sdk/BUILD.gn

diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn

index 38c5b68de6b300ab0e1901b6ac24ace4377dfc1d..4415ccf17beb6d48b610c42145a0db33b8e9dd63 100644

--- a/webrtc/sdk/BUILD.gn

+++ b/webrtc/sdk/BUILD.gn

@@ -260,6 +260,9 @@ if (is_ios || is_mac) {

if (rtc_include_tests) {

rtc_source_set("rtc_sdk_peerconnection_objc_unittests") {

testonly = true

+ if (!is_android && !is_ios) { # Generated targets makes this check break.

+ visibility = [ "//webrtc:rtc_unittests" ]

+ }

sources = [

"objc/Framework/UnitTests/RTCConfigurationTest.mm",

"objc/Framework/UnitTests/RTCDataChannelConfigurationTest.mm",