Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/modules/utility/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/rtp_rtcp/BUILD.gn ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/utility/BUILD.gn
diff --git a/webrtc/modules/utility/BUILD.gn b/webrtc/modules/utility/BUILD.gn
index ae042d4c2237ac02038293304c3f645008eb2523..fdd850477d754022ddab70139e62cbfea3659e7d 100644
--- a/webrtc/modules/utility/BUILD.gn
+++ b/webrtc/modules/utility/BUILD.gn
@@ -42,6 +42,9 @@ rtc_static_library("utility") {
if (rtc_include_tests) {
rtc_source_set("utility_unittests") {
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc/modules:modules_unittests" ]
+ }
sources = [
"source/process_thread_impl_unittest.cc",
]
« webrtc/modules/audio_coding/BUILD.gn ('K') | « webrtc/modules/rtp_rtcp/BUILD.gn ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698