Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: webrtc/modules/congestion_controller/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/congestion_controller/BUILD.gn
diff --git a/webrtc/modules/congestion_controller/BUILD.gn b/webrtc/modules/congestion_controller/BUILD.gn
index a7a67e20f3cab8124101ef278b5a06c3796a290b..84bd356cf472b51b5e7b607c16dbbaf4b9c7d140 100644
--- a/webrtc/modules/congestion_controller/BUILD.gn
+++ b/webrtc/modules/congestion_controller/BUILD.gn
@@ -64,6 +64,9 @@ rtc_static_library("congestion_controller") {
if (rtc_include_tests) {
rtc_source_set("congestion_controller_unittests") {
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc/modules:modules_unittests" ]
+ }
sources = [
"congestion_controller_unittest.cc",
"congestion_controller_unittests_helper.cc",
@@ -86,8 +89,8 @@ if (rtc_include_tests) {
"../../test:test_support",
"../bitrate_controller:bitrate_controller",
"../pacing:pacing",
+ "../remote_bitrate_estimator:mock_remote_bitrate_observer",
"../remote_bitrate_estimator:remote_bitrate_estimator",
- "../remote_bitrate_estimator:remote_bitrate_estimator_unittests",
"../rtp_rtcp:rtp_rtcp",
"//testing/gmock",
]

Powered by Google App Engine
This is Rietveld 408576698