Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: webrtc/modules/audio_processing/BUILD.gn

Issue 2828793003: GN: Tighten up test target visibility + refactorings (Closed)
Patch Set: Disable Win compile warning Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/BUILD.gn
diff --git a/webrtc/modules/audio_processing/BUILD.gn b/webrtc/modules/audio_processing/BUILD.gn
index 5686dc66908dced9a188cb2929b8cf2ee035667d..679109d4f5e2f9d5cb0cdc4fdc19e6c815eb044b 100644
--- a/webrtc/modules/audio_processing/BUILD.gn
+++ b/webrtc/modules/audio_processing/BUILD.gn
@@ -485,6 +485,9 @@ if (rtc_include_tests) {
rtc_source_set("audio_processing_unittests") {
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc/modules:modules_unittests" ]
+ }
sources = [
"aec/echo_cancellation_unittest.cc",
"aec/system_delay_unittest.cc",
@@ -651,6 +654,9 @@ if (rtc_include_tests) {
# //webrtc/modules:_modules_unittests__library
check_includes = false
testonly = true
+ if (!is_android && !is_ios) { # Generated targets makes this check break.
+ visibility = [ "//webrtc:webrtc_perf_tests" ]
+ }
sources = [
"audio_processing_performance_unittest.cc",
"level_controller/level_controller_complexity_unittest.cc",

Powered by Google App Engine
This is Rietveld 408576698