GN: Tighten up test target visibility + refactorings

webrtc/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # TODO(kjellander): Rebase this to webrtc/build/common.gypi changes after r6330.
 
@@ skipping 264 matching lines @@
       testonly = true
 
       # Only the root target should depend on this.
       visibility = [ "//:default" ]
 
       deps = [
         ":rtc_unittests",
         ":video_engine_tests",
         ":webrtc_nonparallel_tests",
         ":webrtc_perf_tests",
-        "api:rtc_api_unittests",

[kjellander_webrtc, 2017/04/21 12:13:59]

The removed targets in here are rtc_source_set targets that are already included
in rtc_test targets that are listed here, so they're redundant.

         "base:rtc_base_tests_utils",
         "common_audio:common_audio_unittests",
         "common_video:common_video_unittests",
         "media:rtc_media_unittests",
         "modules:modules_tests",
         "modules:modules_unittests",
         "modules/audio_coding:audio_coding_tests",
         "modules/audio_processing:audio_processing_tests",
         "modules/remote_bitrate_estimator:bwe_simulations_tests",
         "modules/rtp_rtcp:test_packet_masks_metrics",
         "modules/video_capture:video_capture_internal_impl",
         "modules/video_coding:plot_videoprocessor_integrationtest",
         "ortc:ortc_unittests",
         "pc:peerconnection_unittests",
         "pc:rtc_pc_unittests",
         "stats:rtc_stats_unittests",
         "system_wrappers:system_wrappers_unittests",
         "test",
         "video:screenshare_loopback",
         "video:video_loopback",
-        "video:video_tests",
         "voice_engine:voice_engine_unittests",
       ]
       if (is_android) {
         deps += [
           ":android_junit_tests",
           "//webrtc/sdk/android:libjingle_peerconnection_android_unittest",
         ]
       } else {
         deps += [ "modules/video_capture:video_capture_tests" ]
       }
@@ skipping 151 matching lines @@
     testonly = true
     configs += [ ":rtc_unittests_config" ]
 
     deps = [
       "call:call_perf_tests",
       "modules/audio_coding:audio_coding_perf_tests",
       "modules/audio_processing:audio_processing_perf_tests",
       "modules/remote_bitrate_estimator:remote_bitrate_estimator_perf_tests",
       "test:test_main",
       "video:video_full_stack_tests",
-      "video:video_quality_test",
     ]
 
     data = webrtc_perf_tests_resources
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_native_code" ]
       shard_timeout = 2700
     }
     if (is_ios) {
       deps += [ ":webrtc_perf_tests_bundle_data" ]
     }
@@ skipping 20 matching lines @@
       ]
 
       deps = [
         "//base:base_java_test_support",
         "//webrtc/examples:AppRTCMobile_javalib",
         "//webrtc/sdk/android:libjingle_peerconnection_java",
       ]
     }
   }
 }