Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Side by Side Diff: webrtc/ortc/ortcfactory_unittest.cc

Issue 2828223002: Delete method MessageQueue::set_socketserver (Closed)
Patch Set: Use unique_ptr, fixing one leak in VirtualSocketServerTest. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 10 matching lines...) Expand all
21 21
22 namespace webrtc { 22 namespace webrtc {
23 23
24 // This test uses a virtual network and fake media engine, in order to test the 24 // This test uses a virtual network and fake media engine, in order to test the
25 // OrtcFactory at only an API level. Any end-to-end test should go in 25 // OrtcFactory at only an API level. Any end-to-end test should go in
26 // ortcfactory_integrationtest.cc instead. 26 // ortcfactory_integrationtest.cc instead.
27 class OrtcFactoryTest : public testing::Test { 27 class OrtcFactoryTest : public testing::Test {
28 public: 28 public:
29 OrtcFactoryTest() 29 OrtcFactoryTest()
30 : virtual_socket_server_(&physical_socket_server_), 30 : virtual_socket_server_(&physical_socket_server_),
31 socket_server_scope_(&virtual_socket_server_), 31 thread_(&virtual_socket_server_),
32 fake_packet_transport_("fake transport") { 32 fake_packet_transport_("fake transport") {
33 ortc_factory_ = 33 ortc_factory_ =
34 OrtcFactory::Create(nullptr, nullptr, &fake_network_manager_, nullptr, 34 OrtcFactory::Create(nullptr, nullptr, &fake_network_manager_, nullptr,
35 nullptr, 35 nullptr,
36 std::unique_ptr<cricket::MediaEngineInterface>( 36 std::unique_ptr<cricket::MediaEngineInterface>(
37 new cricket::FakeMediaEngine())) 37 new cricket::FakeMediaEngine()))
38 .MoveValue(); 38 .MoveValue();
39 } 39 }
40 40
41 protected: 41 protected:
42 // Uses a single pre-made FakePacketTransport, so shouldn't be called twice in 42 // Uses a single pre-made FakePacketTransport, so shouldn't be called twice in
43 // the same test. 43 // the same test.
44 std::unique_ptr<RtpTransportInterface> 44 std::unique_ptr<RtpTransportInterface>
45 CreateRtpTransportWithFakePacketTransport() { 45 CreateRtpTransportWithFakePacketTransport() {
46 return ortc_factory_ 46 return ortc_factory_
47 ->CreateRtpTransport(MakeRtcpMuxParameters(), &fake_packet_transport_, 47 ->CreateRtpTransport(MakeRtcpMuxParameters(), &fake_packet_transport_,
48 nullptr, nullptr) 48 nullptr, nullptr)
49 .MoveValue(); 49 .MoveValue();
50 } 50 }
51 51
52 rtc::PhysicalSocketServer physical_socket_server_; 52 rtc::PhysicalSocketServer physical_socket_server_;
53 rtc::VirtualSocketServer virtual_socket_server_; 53 rtc::VirtualSocketServer virtual_socket_server_;
54 rtc::SocketServerScope socket_server_scope_; 54 rtc::AutoSocketServerThread thread_;
55 rtc::FakeNetworkManager fake_network_manager_; 55 rtc::FakeNetworkManager fake_network_manager_;
56 rtc::FakePacketTransport fake_packet_transport_; 56 rtc::FakePacketTransport fake_packet_transport_;
57 std::unique_ptr<OrtcFactoryInterface> ortc_factory_; 57 std::unique_ptr<OrtcFactoryInterface> ortc_factory_;
58 }; 58 };
59 59
60 TEST_F(OrtcFactoryTest, CanCreateMultipleRtpTransportControllers) { 60 TEST_F(OrtcFactoryTest, CanCreateMultipleRtpTransportControllers) {
61 auto controller_result1 = ortc_factory_->CreateRtpTransportController(); 61 auto controller_result1 = ortc_factory_->CreateRtpTransportController();
62 EXPECT_TRUE(controller_result1.ok()); 62 EXPECT_TRUE(controller_result1.ok());
63 auto controller_result2 = ortc_factory_->CreateRtpTransportController(); 63 auto controller_result2 = ortc_factory_->CreateRtpTransportController();
64 EXPECT_TRUE(controller_result1.ok()); 64 EXPECT_TRUE(controller_result1.ok());
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 TEST_F(OrtcFactoryTest, CreateSendersOrReceieversWithNullTransport) { 249 TEST_F(OrtcFactoryTest, CreateSendersOrReceieversWithNullTransport) {
250 auto sender_result = 250 auto sender_result =
251 ortc_factory_->CreateRtpSender(cricket::MEDIA_TYPE_AUDIO, nullptr); 251 ortc_factory_->CreateRtpSender(cricket::MEDIA_TYPE_AUDIO, nullptr);
252 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, sender_result.error().type()); 252 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, sender_result.error().type());
253 auto receiver_result = 253 auto receiver_result =
254 ortc_factory_->CreateRtpReceiver(cricket::MEDIA_TYPE_AUDIO, nullptr); 254 ortc_factory_->CreateRtpReceiver(cricket::MEDIA_TYPE_AUDIO, nullptr);
255 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, receiver_result.error().type()); 255 EXPECT_EQ(RTCErrorType::INVALID_PARAMETER, receiver_result.error().type());
256 } 256 }
257 257
258 } // namespace webrtc 258 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698