webrtc/modules/congestion_controller/include/congestion_controller.h - Issue 2827333005: Moving overhead counting to bitrate estimators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/include/congestion_controller.h

Issue 2827333005: Moving overhead counting to bitrate estimators.

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/congestion_controller/delay_based_bwe_unittest_helper.cc ('k') | webrtc/modules/congestion_controller/include/send_side_congestion_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/include/congestion_controller.h

diff --git a/webrtc/modules/congestion_controller/include/congestion_controller.h b/webrtc/modules/congestion_controller/include/congestion_controller.h

index 0e69047b9a7f7ce2b06316a0650f3dcce79e9f91..2ac14cbcb7321e86d4fcc1a837c3d3c05aa0f71b 100644

--- a/webrtc/modules/congestion_controller/include/congestion_controller.h

+++ b/webrtc/modules/congestion_controller/include/congestion_controller.h

@@ -124,7 +124,8 @@ class CongestionController : public CallStatsObserver,

// Implements TransportFeedbackObserver.

void AddPacket(uint32_t ssrc,

uint16_t sequence_number,

- size_t length,

+ size_t payload_size,

+ size_t rtp_headers_size,

stefan-webrtc 2017/04/21 12:35:27 I don't like this since I want to move towards Con

minyue-webrtc 2017/04/21 12:58:14 I know that and would like to avoid this. But the

const PacedPacketInfo& pacing_info) override;

void OnTransportFeedback(const rtcp::TransportFeedback& feedback) override;

std::vector<PacketFeedback> GetTransportFeedbackVector() const override;