Added -show_detector_state which show the detector state in the total bitrate graph.

webrtc/rtc_tools/event_log_visualizer/plot_python.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 56 matching lines @@
             "marker='.')\n",
             i, i, i, series_list_[i].label.c_str());
       } else if (series_list_[i].style == LINE_STEP_GRAPH) {
         // Draw lines from (x[0],y[0]) to (x[1],y[0]) to (x[1],y[1]) and so on
         // to illustrate the "steps". This can be expressed by duplicating all
         // elements except the first in x and the last in y.
         printf("x%zu = [v for dup in x%zu for v in [dup, dup]]\n", i, i);
         printf("y%zu = [v for dup in y%zu for v in [dup, dup]]\n", i, i);
         printf(
             "plt.plot(x%zu[1:], y%zu[:-1], color=rgb_colors[%zu], "
+            "path_effects=[pe.Stroke(linewidth=2, foreground='black'), "

[terelius, 2017/07/04 12:22:01]

Why do we need to do this at all, and why do we only need to do it for step
graphs?

[philipel, 2017/07/04 12:55:10]

I guess it should be configurable by whoever creates the step graph, but in the
case of the total bitrate figure it looks much better.

+            "pe.Normal()], "
             "label=\'%s\')\n",
             i, i, i, series_list_[i].label.c_str());
       } else if (series_list_[i].style == DOT_GRAPH) {
         printf(
             "plt.plot(x%zu, y%zu, color=rgb_colors[%zu], label=\'%s\', "
             "marker='o', ls=' ')\n",
             i, i, i, series_list_[i].label.c_str());
       } else {
         printf("raise Exception(\"Unknown graph type\")\n");
       }
     }
+
+    // IntervalSeries

[terelius, 2017/07/04 12:22:01]

If this represents the background, shouldn't it be drawn before the normal time
series?

[philipel, 2017/07/04 12:55:10]

They are always in the background.

+    for (size_t i = 0; i < interval_list_.size(); i++) {
+      // List intervals
+      printf("\n# === IntervalSeries: %s ===\n",
+             interval_list_[i].label.c_str());
+      printf("i%zu = [", i);

[terelius, 2017/07/04 12:22:01]

Maybe a longer, more explicit name for the intervals? "i" sounds like an index.

[philipel, 2017/07/04 12:55:10]

Renamed to 'ival'.

+      if (interval_list_[i].intervals.size() > 0) {
+        printf("(%G, %G)", interval_list_[i].intervals[0].begin,
+               interval_list_[i].intervals[0].end);
+      }
+      for (size_t j = 1; j < interval_list_[i].intervals.size(); j++) {

[terelius, 2017/07/04 12:22:01]

Maybe remove the if statement above, loop from 0 and add 
if (j > 0)
  printf(", ")
in the loop?

[philipel, 2017/07/04 12:55:10]

This is consistent with the style above, if we want to change it I think we
should change it in a separate CL.

+        printf(", (%G, %G)", interval_list_[i].intervals[j].begin,
+               interval_list_[i].intervals[j].end);
+      }
+      printf("]\n");
+
+      printf("for i in range(0, %zu):\n", interval_list_[i].intervals.size());
+      if (interval_list_[i].orientation == IntervalSeries::kHorizontal) {
+        printf(
+            "  plt.axhspan(i%zu[i][0], i%zu[i][1], facecolor='%s', "
+            "alpha=0.3)\n",
+            i, i, interval_list_[i].color.c_str());
+      } else {
+        printf(
+            "  plt.axvspan(i%zu[i][0], i%zu[i][1], facecolor='%s', "
+            "alpha=0.3)\n",
+            i, i, interval_list_[i].color.c_str());
+      }
+    }
   }
 
   printf("plt.xlim(%f, %f)\n", xaxis_min_, xaxis_max_);
   printf("plt.ylim(%f, %f)\n", yaxis_min_, yaxis_max_);
   printf("plt.xlabel(\'%s\')\n", xaxis_label_.c_str());
   printf("plt.ylabel(\'%s\')\n", yaxis_label_.c_str());
   printf("plt.title(\'%s\')\n", title_.c_str());
   if (!series_list_.empty()) {
     printf("plt.legend(loc=\'best\', fontsize=\'small\')\n");
   }
 }
 
 PythonPlotCollection::PythonPlotCollection() {}
 
 PythonPlotCollection::~PythonPlotCollection() {}
 
 void PythonPlotCollection::Draw() {
   printf("import matplotlib.pyplot as plt\n");
+  printf("import matplotlib.patheffects as pe\n");
   printf("import colorsys\n");
   for (size_t i = 0; i < plots_.size(); i++) {
     printf("plt.figure(%zu)\n", i);
     plots_[i]->Draw();
   }
   printf("plt.show()\n");
 }
 
 Plot* PythonPlotCollection::AppendNewPlot() {
   Plot* plot = new PythonPlot();
   plots_.push_back(std::unique_ptr<Plot>(plot));
   return plot;
 }
 
 }  // namespace plotting
 }  // namespace webrtc