Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Unified Diff: media/engine/webrtcvideoengine.cc

Issue 2826263004: Move responsibility for RTP header extensions on video receive. (Closed)
Patch Set: Crude rebase. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/engine/fakewebrtccall.cc ('k') | media/engine/webrtcvideoengine_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/engine/webrtcvideoengine.cc
diff --git a/media/engine/webrtcvideoengine.cc b/media/engine/webrtcvideoengine.cc
index 69af25b01d71b4b148d26f901c95269a7963ceb6..045ff1410a9679abce271df7a8a7bd84bf12e392 100644
--- a/media/engine/webrtcvideoengine.cc
+++ b/media/engine/webrtcvideoengine.cc
@@ -1252,8 +1252,6 @@ void WebRtcVideoChannel::ConfigureReceiverRtp(
sp.GetFidSsrc(ssrc, &config->rtp.rtx_ssrc);
- config->rtp.extensions = recv_rtp_extensions_;
-
// TODO(brandtr): Generalize when we add support for multistream protection.
flexfec_config->payload_type = recv_flexfec_payload_type_;
if (IsFlexfecAdvertisedFieldTrialEnabled() &&
@@ -1264,7 +1262,6 @@ void WebRtcVideoChannel::ConfigureReceiverRtp(
// TODO(brandtr): We should be spec-compliant and set |transport_cc| here
// based on the rtcp-fb for the FlexFEC codec, not the media codec.
flexfec_config->transport_cc = config->rtp.transport_cc;
- flexfec_config->rtp_header_extensions = config->rtp.extensions;
}
}
@@ -2344,12 +2341,6 @@ void WebRtcVideoChannel::WebRtcVideoReceiveStream::SetRecvParameters(
ConfigureCodecs(*params.codec_settings, &old_decoders);
video_needs_recreation = true;
}
- if (params.rtp_header_extensions) {
- config_.rtp.extensions = *params.rtp_header_extensions;
- flexfec_config_.rtp_header_extensions = *params.rtp_header_extensions;
- video_needs_recreation = true;
- flexfec_needs_recreation = true;
- }
if (params.flexfec_payload_type) {
ConfigureFlexfecCodec(*params.flexfec_payload_type);
flexfec_needs_recreation = true;
« no previous file with comments | « media/engine/fakewebrtccall.cc ('k') | media/engine/webrtcvideoengine_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698