webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java - Issue 2825313002: Espresso test for loopback video quality testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java

Issue 2825313002: Espresso test for loopback video quality testing (Closed)

Patch Set: Use exception instead of manual log Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/examples/BUILD.gn ('k') | webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java » ('j') | webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java

diff --git a/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java b/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java

index 72a449bb440e812671e3f6e29d7fbf08f8102165..e88d1a849fdcac0beea6014cc119509c58af6da0 100644

--- a/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java

+++ b/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java

@@ -27,10 +27,16 @@ public interface AppRTCClient {

public final String roomUrl;

public final String roomId;

public final boolean loopback;

- public RoomConnectionParameters(String roomUrl, String roomId, boolean loopback) {

+ public final String colliderUrl;

+ public RoomConnectionParameters(

+ String roomUrl, String roomId, boolean loopback, String colliderUrl) {

this.roomUrl = roomUrl;

this.roomId = roomId;

this.loopback = loopback;

+ this.colliderUrl = colliderUrl;

+ }

+ public RoomConnectionParameters(String roomUrl, String roomId, boolean loopback) {

+ this(roomUrl, roomId, loopback, null);

magjed_webrtc 2017/04/20 13:53:30 nit: Add literal comment, i.e. null /* colliderUrl

oprypin_webrtc 2017/04/20 15:46:15 Will do.

}