webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java - Issue 2825313002: Espresso test for loopback video quality testing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java

Issue 2825313002: Espresso test for loopback video quality testing (Closed)

Patch Set: Rework colliderUrl as urlParameters Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java ('k') | webrtc/examples/androidtests/src/org/appspot/apprtc/test/CallActivityStubbedInputOutputTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java

diff --git a/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java b/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java

index 28eef2e51e5f55f54835f14a2ec4a4ddc286578a..5e8380ae0c14025d4f82cfabb7a2088bece389bc 100644

--- a/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java

+++ b/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java

@@ -131,7 +131,11 @@ public class WebSocketRTCClient implements AppRTCClient, WebSocketChannelEvents

// Helper functions to get connection, post message and leave message URLs

private String getConnectionUrl(RoomConnectionParameters connectionParameters) {

- return connectionParameters.roomUrl + "/" + ROOM_JOIN + "/" + connectionParameters.roomId;

+ String url = connectionParameters.roomUrl + "/" + ROOM_JOIN + "/" + connectionParameters.roomId;

+ if (connectionParameters.urlParameters != null) {

+ url += "?" + connectionParameters.urlParameters;

+ }

+ return url;

}

private String getMessageUrl(