Espresso test for loopback video quality testing

webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java

 /*
  *  Copyright 2014 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 113 matching lines @@
       sendPostMessage(MessageType.LEAVE, leaveUrl, null);
     }
     roomState = ConnectionState.CLOSED;
     if (wsClient != null) {
       wsClient.disconnect(true);
     }
   }
 
   // Helper functions to get connection, post message and leave message URLs
   private String getConnectionUrl(RoomConnectionParameters connectionParameters) {
-    return connectionParameters.roomUrl + "/" + ROOM_JOIN + "/" + connectionParameters.roomId;
+    StringBuilder builder = new StringBuilder(
+        connectionParameters.roomUrl + "/" + ROOM_JOIN + "/" + connectionParameters.roomId);
+    if (connectionParameters.colliderUrl != null) {
+      // TODO false for wstls to disable https, should be option later or if URL is http
+      builder.append("?wstls=false");
+      builder.append("?debug=loopback");

[magjed_webrtc, 2017/04/20 13:53:30]

This seems unrelated to colliderUrl. Maybe we should add a single String
parameter for all the url parameters?

[magjed_webrtc, 2017/04/20 13:53:30]

Don't you need to use '&' instead of '?' for the following arguments?

[oprypin_webrtc, 2017/04/20 15:46:15]

To me this kinda makes sense - if collider URL is present, then enable some
debug flags, including passing collider URL.
I'm not sure what you mean about a single String parameter.

[oprypin_webrtc, 2017/04/20 15:46:15]

Probably. I'll check if the test still works with &

[magjed_webrtc, 2017/04/21 08:23:09]

I was thinking we should have a String parameter 'urlParameters' instead of
'colliderUrl', and pass in all of "wstls=false&debug=loopback&ts=&wshpp=xxx".

Btw, why do we need 'debug=loopback'? We already have a boolean in
RoomConnectionParameters named 'loopback', why can't we use that?

[oprypin_webrtc, 2017/04/24 10:08:06]

Turns out having all '?' works, and having '&' on following arguments does not.

[oprypin_webrtc, 2017/04/24 10:41:10]

Done.
RoomConnectionParameters loopback is indeed enabled, but this is a different
setting that is also needed -- this is actually being passed to the AppEngine
dev server, you can find out more about this complex interaction in the Python
script.

+      builder.append("?ts=");
+      builder.append("?wshpp=").append(connectionParameters.colliderUrl);
+    }
+    return builder.toString();
   }
 
   private String getMessageUrl(
       RoomConnectionParameters connectionParameters, SignalingParameters signalingParameters) {
     return connectionParameters.roomUrl + "/" + ROOM_MESSAGE + "/" + connectionParameters.roomId
         + "/" + signalingParameters.clientId;
   }
 
   private String getLeaveUrl(
       RoomConnectionParameters connectionParameters, SignalingParameters signalingParameters) {
@@ skipping 265 matching lines @@
     jsonPut(json, "candidate", candidate.sdp);
     return json;
   }
 
   // Converts a JSON candidate to a Java object.
   IceCandidate toJavaCandidate(JSONObject json) throws JSONException {
     return new IceCandidate(
         json.getString("id"), json.getInt("label"), json.getString("candidate"));
   }
 }