Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: media/base/android/media_drm_storage_bridge.h

Issue 2823513002: [Clank] Load origin id before create MediaDrmBridge (Closed)
Patch Set: Rebase + Nit Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/android/media_drm_bridge_unittest.cc ('k') | media/base/android/media_drm_storage_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/android/media_drm_storage_bridge.h
diff --git a/media/base/android/media_drm_storage_bridge.h b/media/base/android/media_drm_storage_bridge.h
index 955e570126c98a95db1b0532ea19b51e7f38e618..e9e9689d96c74e9debcb4f4b393b47dc99669e2a 100644
--- a/media/base/android/media_drm_storage_bridge.h
+++ b/media/base/android/media_drm_storage_bridge.h
@@ -29,10 +29,18 @@ class MediaDrmStorageBridge {
public:
static bool RegisterMediaDrmStorageBridge(JNIEnv* env);
- MediaDrmStorageBridge(const url::Origin& origin,
- const CreateStorageCB& create_storage_cb);
+ MediaDrmStorageBridge();
~MediaDrmStorageBridge();
+ // Bind origin to |this|. Once storage is initialized, |on_init| will be
+ // called and it will have a random generated origin id for later usage. If
+ // this function isn't called, all the other functions will fail.
+ void Initialize(const url::Origin& origin,
+ const CreateStorageCB& create_storage_cb,
+ base::OnceClosure init_cb);
+
+ std::string origin_id() const { return origin_id_; }
+
// The following OnXXX functions are called by Java. The functions will post
// task on message loop immediately to avoid reentrancy issues.
@@ -73,12 +81,10 @@ class MediaDrmStorageBridge {
const std::string& session_id,
std::unique_ptr<MediaDrmStorage::SessionData> session_data);
- MediaDrmStorage* GetStorageImpl();
-
- CreateStorageCB create_storage_cb_;
std::unique_ptr<MediaDrmStorage> impl_;
- const url::Origin origin_;
+ // Randomly generated ID for origin.
+ std::string origin_id_;
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
« no previous file with comments | « media/base/android/media_drm_bridge_unittest.cc ('k') | media/base/android/media_drm_storage_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698