webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm - Issue 2822233002: Don't call unconfigureWebRTCSession if setConfiguration fails. webrtc:7471

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm

Issue 2822233002: Don't call unconfigureWebRTCSession if setConfiguration fails. webrtc:7471 (Closed)

Patch Set: updated' Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm

diff --git a/webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm b/webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm

index f4530167f943928e7fe4ef5fb2ada88a273edc52..84cc6da4e436d566c007461912cd183bc3b3a9bf 100644

--- a/webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm

+++ b/webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm

@@ -688,7 +688,7 @@ NSInteger const kRTCAudioSessionErrorConfiguration = -2;

if (![self setConfiguration:webRTCConfig active:YES error:&error]) {

RTCLogError(@"Failed to set WebRTC audio configuration: %@",

error.localizedDescription);

- [self unconfigureWebRTCSession:nil];

+ // Do not call setActive:NO if setActive:YES failed.

if (outError) {

*outError = error;

}