Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h

Issue 2818433003: Enabling 'gn check' on webrtc/sdk (Closed)
Patch Set: Re-adding a wrongly removed dependency Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h b/webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h
index 00d3fa6930f94954207fdcde43b62bbd75a03e97..609fc74fe83724e4609b2541e3e63f6ee972dfea 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h
+++ b/webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h
@@ -10,7 +10,10 @@
#import "WebRTC/RTCMetricsSampleInfo.h"
-#include "webrtc/system_wrappers/include/metrics_default.h"
+// Adding 'nogncheck' to disable the gn include headers check.
+// We don't want to depend on 'system_wrappers:metrics_default' because
+// clients should be able to provide their own implementation.
+#include "webrtc/system_wrappers/include/metrics_default.h" // nogncheck
NS_ASSUME_NONNULL_BEGIN
« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698