Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(888)

Side by Side Diff: webrtc/sdk/objc/Framework/Classes/RTCFieldTrials.mm

Issue 2818433003: Enabling 'gn check' on webrtc/sdk (Closed)
Patch Set: Re-adding a wrongly removed dependency Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #import "WebRTC/RTCFieldTrials.h" 11 #import "WebRTC/RTCFieldTrials.h"
12 12
13 #include <memory> 13 #include <memory>
14 14
15 #import "WebRTC/RTCLogging.h" 15 #import "WebRTC/RTCLogging.h"
16 16
17 #include "webrtc/system_wrappers/include/field_trial_default.h" 17 // Adding 'nogncheck' to disable the gn include headers check.
18 // We don't want to depend on 'system_wrappers:field_trial_default' because
19 // clients should be able to provide their own implementation.
20 #include "webrtc/system_wrappers/include/field_trial_default.h" // nogncheck
18 21
19 NSString * const kRTCFieldTrialAudioSendSideBweKey = @"WebRTC-Audio-SendSideBwe" ; 22 NSString * const kRTCFieldTrialAudioSendSideBweKey = @"WebRTC-Audio-SendSideBwe" ;
20 NSString * const kRTCFieldTrialSendSideBweWithOverheadKey = @"WebRTC-SendSideBwe -WithOverhead"; 23 NSString * const kRTCFieldTrialSendSideBweWithOverheadKey = @"WebRTC-SendSideBwe -WithOverhead";
21 NSString * const kRTCFieldTrialFlexFec03AdvertisedKey = @"WebRTC-FlexFEC-03-Adve rtised"; 24 NSString * const kRTCFieldTrialFlexFec03AdvertisedKey = @"WebRTC-FlexFEC-03-Adve rtised";
22 NSString * const kRTCFieldTrialFlexFec03Key = @"WebRTC-FlexFEC-03"; 25 NSString * const kRTCFieldTrialFlexFec03Key = @"WebRTC-FlexFEC-03";
23 NSString * const kRTCFieldTrialImprovedBitrateEstimateKey = @"WebRTC-ImprovedBit rateEstimate"; 26 NSString * const kRTCFieldTrialImprovedBitrateEstimateKey = @"WebRTC-ImprovedBit rateEstimate";
24 NSString * const kRTCFieldTrialMedianSlopeFilterKey = @"WebRTC-BweMedianSlopeFil ter"; 27 NSString * const kRTCFieldTrialMedianSlopeFilterKey = @"WebRTC-BweMedianSlopeFil ter";
25 NSString * const kRTCFieldTrialTrendlineFilterKey = @"WebRTC-BweTrendlineFilter" ; 28 NSString * const kRTCFieldTrialTrendlineFilterKey = @"WebRTC-BweTrendlineFilter" ;
26 NSString * const kRTCFieldTrialH264HighProfileKey = @"WebRTC-H264HighProfile"; 29 NSString * const kRTCFieldTrialH264HighProfileKey = @"WebRTC-H264HighProfile";
27 NSString * const kRTCFieldTrialEnabledValue = @"Enabled"; 30 NSString * const kRTCFieldTrialEnabledValue = @"Enabled";
(...skipping 27 matching lines...) Expand all
55 size_t len = fieldTrialInitString.length + 1; 58 size_t len = fieldTrialInitString.length + 1;
56 gFieldTrialInitString.reset(new char[len]); 59 gFieldTrialInitString.reset(new char[len]);
57 if (![fieldTrialInitString getCString:gFieldTrialInitString.get() 60 if (![fieldTrialInitString getCString:gFieldTrialInitString.get()
58 maxLength:len 61 maxLength:len
59 encoding:NSUTF8StringEncoding]) { 62 encoding:NSUTF8StringEncoding]) {
60 RTCLogError(@"Failed to convert field trial string."); 63 RTCLogError(@"Failed to convert field trial string.");
61 return; 64 return;
62 } 65 }
63 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get()); 66 webrtc::field_trial::InitFieldTrialsFromString(gFieldTrialInitString.get());
64 } 67 }
OLDNEW
« no previous file with comments | « webrtc/sdk/android/src/jni/peerconnection_jni.cc ('k') | webrtc/sdk/objc/Framework/Classes/RTCMetricsSampleInfo+Private.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698