Enabling 'gn check' on webrtc/sdk

webrtc/sdk/android/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//webrtc/webrtc.gni")
 import("//build/config/android/config.gni")
@@ skipping 51 matching lines @@
   configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
 
   if (is_win) {
     cflags += [
       "/wd4245",  # conversion from "int" to "size_t", signed/unsigned mismatch.
       "/wd4389",  # signed/unsigned mismatch.
     ]
   }
 
   deps = [
+    "../..:webrtc_common",
+    "../../api:video_frame_api",
+    "../../api/video_codecs:video_codecs_api",
+    "../../base:rtc_base",
+    "../../base:rtc_base_approved",
+    "../../base:rtc_task_queue",
+    "../../common_video:common_video",
+    "../../media:rtc_media",
+    "../../media:rtc_media_base",
+    "../../modules/utility:utility",
+    "../../modules/video_coding:video_coding_utility",
+    "../../system_wrappers:field_trial_default",

[kjellander_webrtc, 2017/04/19 10:04:38]

I don't think we should have this.

+    "../../system_wrappers:system_wrappers",
+    "../../voice_engine:voice_engine",
     "//webrtc/pc:libjingle_peerconnection",
   ]
 
   if (rtc_build_libyuv) {
     deps += [ "$rtc_libyuv_dir" ]
     public_deps = [
       "$rtc_libyuv_dir",
     ]
   } else {
     # Need to add a directory normally exported by libyuv.
     include_dirs = [ "$rtc_libyuv_dir/include" ]
   }
 }
 
 rtc_static_library("libjingle_peerconnection_metrics_default_jni") {
   sources = [
     "src/jni/androidmetrics_jni.cc",
   ]
 
   configs += [ ":libjingle_peerconnection_jni_warnings_config" ]
 
   deps = [
+    ":libjingle_peerconnection_jni",
+    "../../system_wrappers",
     "//webrtc/pc:libjingle_peerconnection",
     "//webrtc/system_wrappers:field_trial_default",
     "//webrtc/system_wrappers:metrics_default",
   ]
 }
 
 rtc_shared_library("libjingle_peerconnection_so") {
   sources = [
     "src/jni/jni_onload.cc",
   ]
 
   suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ]
   configs += [ "//build/config/android:hide_all_but_jni" ]
 
   deps = [
     ":libjingle_peerconnection_jni",
     ":libjingle_peerconnection_metrics_default_jni",
+    "../../base:rtc_base",
     "//webrtc/pc:libjingle_peerconnection",
   ]
   output_extension = "so"
 }
 
 dist_jar("libwebrtc") {
   _target_dir_name = get_label_info(":$target_name", "dir")
   output = "${root_out_dir}/lib.java${_target_dir_name}/${target_name}.jar"
   direct_deps_only = true
   use_interface_jars = false
@@ skipping 115 matching lines @@
       "//third_party/android_support_test_runner:runner_java",
       "//third_party/junit",
       "//webrtc/base:base_java",
       "//webrtc/sdk/android:libjingle_peerconnection_java",
       "//webrtc/sdk/android:libjingle_peerconnection_metrics_default_java",
     ]
 
     shared_libraries = [ "//webrtc/sdk/android:libjingle_peerconnection_so" ]
   }
 }