Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h

Issue 2815843002: Log to RtcEventLog when loss based estimate is changed. (Closed)
Patch Set: Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
diff --git a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
index 84ee882982bdd465ede7b9a3923cea8f6969e984..fd1b30f2e58b289490de12011e7f844872eb03be 100644
--- a/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
+++ b/webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.h
@@ -60,22 +60,20 @@ class SendSideBandwidthEstimation {
void UpdateUmaStats(int64_t now_ms, int64_t rtt, int lost_packets);
- // Returns the input bitrate capped to the thresholds defined by the max,
- // min and incoming bandwidth.
- uint32_t CapBitrateToThresholds(int64_t now_ms, uint32_t bitrate);
-
// Updates history of min bitrates.
// After this method returns min_bitrate_history_.front().second contains the
// min bitrate used during last kBweIncreaseIntervalMs.
void UpdateMinHistory(int64_t now_ms);
+ void CapAndLogBitrate(int64_t now_ms, uint32_t bitrate_bps);
terelius 2017/04/18 12:09:58 nit: Please add a comment that mentions clipping t
philipel 2017/04/18 12:55:12 Done.
+
std::deque<std::pair<int64_t, uint32_t> > min_bitrate_history_;
// incoming filters
int lost_packets_since_last_loss_update_Q8_;
int expected_packets_since_last_loss_update_;
- uint32_t bitrate_;
+ uint32_t current_bitrate_bps_;
uint32_t min_bitrate_configured_;
uint32_t max_bitrate_configured_;
int64_t last_low_bitrate_log_ms_;

Powered by Google App Engine
This is Rietveld 408576698