Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: webrtc/pc/channel.h

Issue 2815513012: Negotiate the same SRTP crypto suites for every DTLS association formed. (Closed)
Patch Set: Merge with master Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/transportcontroller.cc ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel.h
diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h
index 2bec643b47a09bc9440e61deaa67307477d6ba1f..56d51f64daa94656311876f1d0a258f67a1e241d 100644
--- a/webrtc/pc/channel.h
+++ b/webrtc/pc/channel.h
@@ -203,8 +203,6 @@ class BaseChannel
virtual cricket::MediaType media_type() = 0;
- bool SetCryptoOptions(const rtc::CryptoOptions& crypto_options);
-
// This function returns true if we require SRTP for call setup.
bool srtp_required_for_testing() const { return srtp_required_; }
@@ -306,8 +304,6 @@ class BaseChannel
// |rtcp_channel| indicates whether to set up the RTP or RTCP filter.
bool SetupDtlsSrtp_n(bool rtcp);
void MaybeSetupDtlsSrtp_n();
- // Set the DTLS-SRTP cipher policy on this channel as appropriate.
- bool SetDtlsSrtpCryptoSuites_n(DtlsTransportInternal* transport, bool rtcp);
// Should be called whenever the conditions for
// IsReadyToReceiveMedia/IsReadyToSendMedia are satisfied (or unsatisfied).
@@ -359,13 +355,7 @@ class BaseChannel
// From MessageHandler
void OnMessage(rtc::Message* pmsg) override;
- const rtc::CryptoOptions& crypto_options() const {
- return crypto_options_;
- }
-
// Handled in derived classes
- // Get the SRTP crypto suites to use for RTP media
- virtual void GetSrtpCryptoSuites_n(std::vector<int>* crypto_suites) const = 0;
virtual void OnConnectionMonitorUpdate(ConnectionMonitor* monitor,
const std::vector<ConnectionInfo>& infos) = 0;
@@ -419,7 +409,6 @@ class BaseChannel
bool has_received_packet_ = false;
bool dtls_keyed_ = false;
const bool srtp_required_ = true;
- rtc::CryptoOptions crypto_options_;
int rtp_abs_sendtime_extn_id_ = -1;
// MediaChannel related members that should be accessed from the worker
@@ -534,7 +523,6 @@ class VoiceChannel : public BaseChannel {
bool SetOutputVolume_w(uint32_t ssrc, double volume);
void OnMessage(rtc::Message* pmsg) override;
- void GetSrtpCryptoSuites_n(std::vector<int>* crypto_suites) const override;
void OnConnectionMonitorUpdate(
ConnectionMonitor* monitor,
const std::vector<ConnectionInfo>& infos) override;
@@ -617,7 +605,6 @@ class VideoChannel : public BaseChannel {
webrtc::RtpParameters parameters);
void OnMessage(rtc::Message* pmsg) override;
- void GetSrtpCryptoSuites_n(std::vector<int>* crypto_suites) const override;
void OnConnectionMonitorUpdate(
ConnectionMonitor* monitor,
const std::vector<ConnectionInfo>& infos) override;
@@ -726,7 +713,6 @@ class RtpDataChannel : public BaseChannel {
void UpdateMediaSendRecvState_w() override;
void OnMessage(rtc::Message* pmsg) override;
- void GetSrtpCryptoSuites_n(std::vector<int>* crypto_suites) const override;
void OnConnectionMonitorUpdate(
ConnectionMonitor* monitor,
const std::vector<ConnectionInfo>& infos) override;
« no previous file with comments | « webrtc/p2p/base/transportcontroller.cc ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698