Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2309)

Unified Diff: webrtc/p2p/base/transportcontroller.cc

Issue 2815513012: Negotiate the same SRTP crypto suites for every DTLS association formed. (Closed)
Patch Set: Prefer 32-bit HMAC by default. Also cleaning up some things. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/transportcontroller.cc
diff --git a/webrtc/p2p/base/transportcontroller.cc b/webrtc/p2p/base/transportcontroller.cc
index f06a180088608301c7d73560a346b42383b69481..69e53243c5b087997207520f35b4d69a8b919d9c 100644
--- a/webrtc/p2p/base/transportcontroller.cc
+++ b/webrtc/p2p/base/transportcontroller.cc
@@ -65,22 +65,17 @@ class TransportController::ChannelPair {
RTC_DISALLOW_COPY_AND_ASSIGN(ChannelPair);
};
-TransportController::TransportController(rtc::Thread* signaling_thread,
- rtc::Thread* network_thread,
- PortAllocator* port_allocator,
- bool redetermine_role_on_ice_restart)
+TransportController::TransportController(
+ rtc::Thread* signaling_thread,
+ rtc::Thread* network_thread,
+ PortAllocator* port_allocator,
+ bool redetermine_role_on_ice_restart,
+ const rtc::CryptoOptions& crypto_options)
: signaling_thread_(signaling_thread),
network_thread_(network_thread),
port_allocator_(port_allocator),
- redetermine_role_on_ice_restart_(redetermine_role_on_ice_restart) {}
-
-TransportController::TransportController(rtc::Thread* signaling_thread,
- rtc::Thread* network_thread,
- PortAllocator* port_allocator)
- : TransportController(signaling_thread,
- network_thread,
- port_allocator,
- true) {}
+ redetermine_role_on_ice_restart_(redetermine_role_on_ice_restart),
+ crypto_options_(crypto_options) {}
TransportController::~TransportController() {
// Channel destructors may try to send packets, so this needs to happen on
@@ -362,7 +357,7 @@ DtlsTransportInternal* TransportController::CreateDtlsTransportChannel_n(
const std::string&,
int,
IceTransportInternal* ice) {
- DtlsTransport* dtls = new DtlsTransport(ice);
+ DtlsTransport* dtls = new DtlsTransport(ice, crypto_options_);
dtls->SetSslMaxProtocolVersion(ssl_max_version_);
return dtls;
}

Powered by Google App Engine
This is Rietveld 408576698