Negotiate the same SRTP crypto suites for every DTLS association formed.

webrtc/p2p/base/transportcontroller.h

 /*
  *  Copyright 2015 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 24 matching lines @@
 }
 
 namespace cricket {
 
 class TransportController : public sigslot::has_slots<>,
                             public rtc::MessageHandler {
  public:
   // If |redetermine_role_on_ice_restart| is true, ICE role is redetermined
   // upon setting a local transport description that indicates an ICE restart.
   // For the constructor that doesn't take this parameter, it defaults to true.
+  //
+  // |crypto_options| is used to determine if created DTLS transports negotiate
+  // GCM crypto suites or not.
   TransportController(rtc::Thread* signaling_thread,
                       rtc::Thread* network_thread,
                       PortAllocator* port_allocator,
-                      bool redetermine_role_on_ice_restart);
-
-  TransportController(rtc::Thread* signaling_thread,
-                      rtc::Thread* network_thread,
-                      PortAllocator* port_allocator);
+                      bool redetermine_role_on_ice_restart,
+                      const rtc::CryptoOptions& crypto_options);
 
   virtual ~TransportController();
 
   rtc::Thread* signaling_thread() const { return signaling_thread_; }
   rtc::Thread* network_thread() const { return network_thread_; }
 
   PortAllocator* port_allocator() const { return port_allocator_; }
 
   // Can only be set before transports are created.
   // TODO(deadbeef): Make this an argument to the constructor once BaseSession
@@ skipping 192 matching lines @@
 
   // Aggregate state for TransportChannelImpls.
   IceConnectionState connection_state_ = kIceConnectionConnecting;
   bool receiving_ = false;
   IceGatheringState gathering_state_ = kIceGatheringNew;
 
   IceConfig ice_config_;
   IceRole ice_role_ = ICEROLE_CONTROLLING;
   bool redetermine_role_on_ice_restart_;
   uint64_t ice_tiebreaker_ = rtc::CreateRandomId64();
+  rtc::CryptoOptions crypto_options_;
   rtc::SSLProtocolVersion ssl_max_version_ = rtc::SSL_PROTOCOL_DTLS_12;

[pthatcher1, 2017/04/17 22:12:41]

Should we move ssl_max_version_ into CryptoOptions?

[Taylor Brandstetter, 2017/04/20 07:20:40]

Seems like a good idea (though for a separate CL).

   rtc::scoped_refptr<rtc::RTCCertificate> certificate_;
   rtc::AsyncInvoker invoker_;
   // True if QUIC is used instead of DTLS.
   bool quic_ = false;
 
   webrtc::MetricsObserverInterface* metrics_observer_ = nullptr;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(TransportController);
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_TRANSPORTCONTROLLER_H_