Negotiate the same SRTP crypto suites for every DTLS association formed.

webrtc/p2p/base/faketransportcontroller.h

 /*
  *  Copyright 2009 The WebRTC Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 17 matching lines @@
 // object for test purposes. Can be connected to other FakeTransportControllers
 // via Connect().
 //
 // This fake is unusual in that for the most part, it's implemented with the
 // real TransportController code, but with fake TransportChannels underneath.
 class FakeTransportController : public TransportController {
  public:
   FakeTransportController()
       : TransportController(rtc::Thread::Current(),
                             rtc::Thread::Current(),
-                            nullptr) {}
+                            nullptr,
+                            /*redetermine_role_on_ice_restart=*/true,

[Taylor Brandstetter, 2017/04/17 22:00:34]

I know we don't use this style typically, but I think we should allow it (when
sensible) since it's more consistent with Google style and it's enforceable by
clang-tidy
(https://clang.llvm.org/extra/clang-tidy/checks/misc-argument-comment.html).
WDYT?

[pthatcher1, 2017/04/17 22:12:41]

I don't like the look of it, but it seems like a good choice in this instance
since it's difficult to make a named variable to pass into  the constructor.

+                            rtc::CryptoOptions()) {}
 
   explicit FakeTransportController(bool redetermine_role_on_ice_restart)
       : TransportController(rtc::Thread::Current(),
                             rtc::Thread::Current(),
                             nullptr,
-                            redetermine_role_on_ice_restart) {}
+                            redetermine_role_on_ice_restart,
+                            rtc::CryptoOptions()) {}
 
   explicit FakeTransportController(IceRole role)
       : TransportController(rtc::Thread::Current(),
                             rtc::Thread::Current(),
-                            nullptr) {
+                            nullptr,
+                            /*redetermine_role_on_ice_restart=*/true,
+                            rtc::CryptoOptions()) {
     SetIceRole(role);
   }
 
   explicit FakeTransportController(rtc::Thread* network_thread)
-      : TransportController(rtc::Thread::Current(), network_thread, nullptr) {}
+      : TransportController(rtc::Thread::Current(),
+                            network_thread,
+                            nullptr,
+                            /*redetermine_role_on_ice_restart=*/true,
+                            rtc::CryptoOptions()) {}
 
   FakeTransportController(rtc::Thread* network_thread, IceRole role)
-      : TransportController(rtc::Thread::Current(), network_thread, nullptr) {
+      : TransportController(rtc::Thread::Current(),
+                            network_thread,
+                            nullptr,
+                            /*redetermine_role_on_ice_restart=*/true,
+                            rtc::CryptoOptions()) {
     SetIceRole(role);
   }
 
   FakeDtlsTransport* GetFakeDtlsTransport_n(const std::string& transport_name,
                                             int component) {
     return static_cast<FakeDtlsTransport*>(
         get_channel_for_testing(transport_name, component));
   }
 
   // Simulate the exchange of transport descriptions, and the gathering and
@@ skipping 69 matching lines @@
         bool asymmetric = false;
         local->SetDestination(remote, asymmetric);
       }
     }
   }
 };
 
 }  // namespace cricket
 
 #endif  // WEBRTC_P2P_BASE_FAKETRANSPORTCONTROLLER_H_