Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1729)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2814313002: Disable EndToEndTest.ContentTypeSwitches test on Windows due to flakiness (Closed)
Patch Set: Disable EndToEndTest.ContentTypeSwitches test on Windows due to flakiness Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 2675 matching lines...) Expand 10 before | Expand all | Expand 10 after
2686 2686
2687 int num_red_samples = use_red ? 1 : 0; 2687 int num_red_samples = use_red ? 1 : 0;
2688 EXPECT_EQ(num_red_samples, 2688 EXPECT_EQ(num_red_samples,
2689 metrics::NumSamples("WebRTC.Video.FecBitrateSentInKbps")); 2689 metrics::NumSamples("WebRTC.Video.FecBitrateSentInKbps"));
2690 EXPECT_EQ(num_red_samples, 2690 EXPECT_EQ(num_red_samples,
2691 metrics::NumSamples("WebRTC.Video.FecBitrateReceivedInKbps")); 2691 metrics::NumSamples("WebRTC.Video.FecBitrateReceivedInKbps"));
2692 EXPECT_EQ(num_red_samples, 2692 EXPECT_EQ(num_red_samples,
2693 metrics::NumSamples("WebRTC.Video.ReceivedFecPacketsInPercent")); 2693 metrics::NumSamples("WebRTC.Video.ReceivedFecPacketsInPercent"));
2694 } 2694 }
2695 2695
2696 TEST_F(EndToEndTest, ContentTypeSwitches) { 2696 #if defined(WEBRTC_WIN)
2697 // Disabled due to flakiness on Windows (bugs.webrtc.org/7483).
2698 #define MAYBE_ContentTypeSwitches DISABLED_ContentTypeSwitches
2699 #else
2700 #define MAYBE_ContentTypeSwitches ContentTypeSwitches
2701 #endif
2702 TEST_F(EndToEndTest, MAYBE_ContentTypeSwitches) {
2697 class StatsObserver : public test::BaseTest, 2703 class StatsObserver : public test::BaseTest,
2698 public rtc::VideoSinkInterface<VideoFrame> { 2704 public rtc::VideoSinkInterface<VideoFrame> {
2699 public: 2705 public:
2700 StatsObserver() : BaseTest(kLongTimeoutMs), num_frames_received_(0) {} 2706 StatsObserver() : BaseTest(kLongTimeoutMs), num_frames_received_(0) {}
2701 2707
2702 bool ShouldCreateReceivers() const override { return true; } 2708 bool ShouldCreateReceivers() const override { return true; }
2703 2709
2704 void OnFrame(const VideoFrame& video_frame) override { 2710 void OnFrame(const VideoFrame& video_frame) override {
2705 // The RTT is needed to estimate |ntp_time_ms| which is used by 2711 // The RTT is needed to estimate |ntp_time_ms| which is used by
2706 // end-to-end delay stats. Therefore, start counting received frames once 2712 // end-to-end delay stats. Therefore, start counting received frames once
(...skipping 1756 matching lines...) Expand 10 before | Expand all | Expand 10 after
4463 std::unique_ptr<VideoEncoder> encoder_; 4469 std::unique_ptr<VideoEncoder> encoder_;
4464 std::unique_ptr<VideoDecoder> decoder_; 4470 std::unique_ptr<VideoDecoder> decoder_;
4465 rtc::CriticalSection crit_; 4471 rtc::CriticalSection crit_;
4466 int recorded_frames_ GUARDED_BY(crit_); 4472 int recorded_frames_ GUARDED_BY(crit_);
4467 } test(this); 4473 } test(this);
4468 4474
4469 RunBaseTest(&test); 4475 RunBaseTest(&test);
4470 } 4476 }
4471 4477
4472 } // namespace webrtc 4478 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698