webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h - Issue 2812533003: ObjC: RTCVideoSource cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h

Issue 2812533003: ObjC: RTCVideoSource cleanup (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/objcvideotracksource.h ('k') | webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCapturer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h

diff --git a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h

index 8b19dd679a9be4dae91050c065ff95eea7850861..723a5cd71fc36974c632f11950a598630a2af9c8 100644

--- a/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h

+++ b/webrtc/sdk/objc/Framework/Headers/WebRTC/RTCPeerConnectionFactory.h

@@ -42,10 +42,15 @@ RTC_EXPORT

- (RTCAudioTrack *)audioTrackWithSource:(RTCAudioSource *)source

trackId:(NSString *)trackId;

-/** Initialize an RTCAVFoundationVideoSource with constraints. */

+/** Initialize an RTCAVFoundationVideoSource with constraints.

+ * Deprecated. Use a generic RTCVideoSource together with RTCCameraVideoCapturer instead.

+ */

daniela-webrtc 2017/04/11 08:10:08 Do we want to add compiler annotation as well? -

magjed_webrtc 2017/04/11 11:11:30 That's probably a good idea to do in the future. O

- (RTCAVFoundationVideoSource *)avFoundationVideoSourceWithConstraints:

(nullable RTCMediaConstraints *)constraints;

+/** Initialize a generic RTCVideoSource. The RTCVideoSource should be passed to a RTCVideoCapturer

+ * implementation, e.g. RTCCameraVideoCapturer, in order to produce frames.

+ */

- (RTCVideoSource *)videoSource;

/** Initialize an RTCVideoTrack with a source and an id. */