Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Unified Diff: webrtc/pc/channel.h

Issue 2812243005: Move ready to send logic from BaseChannel to RtpTransport. (Closed)
Patch Set: Remove dcheck that does not currently hold. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel.h
diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h
index 56d51f64daa94656311876f1d0a258f67a1e241d..48259e5fd9d7732b94c4deaa817265edf5b85b59 100644
--- a/webrtc/pc/channel.h
+++ b/webrtc/pc/channel.h
@@ -183,16 +183,8 @@ class BaseChannel
bool NeedsRtcpTransport();
- // Made public for easier testing.
- //
- // Updates "ready to send" for an individual channel, and informs the media
- // channel that the transport is ready to send if each channel (in use) is
- // ready to send. This is more specific than just "writable"; it means the
- // last send didn't return ENOTCONN.
- //
- // This should be called whenever a channel's ready-to-send state changes,
- // or when RTCP muxing becomes active/inactive.
- void SetTransportChannelReadyToSend(bool rtcp, bool ready);
+ // From RtpTransport - public for testing only
+ void OnTransportReadyToSend(bool ready);
// Only public for unit tests. Otherwise, consider protected.
int SetOption(SocketType type, rtc::Socket::Option o, int val)
@@ -261,7 +253,6 @@ class BaseChannel
size_t len,
const rtc::PacketTime& packet_time,
int flags);
- void OnReadyToSend(rtc::PacketTransportInternal* transport);
void OnDtlsState(DtlsTransportInternal* transport, DtlsTransportState state);
@@ -391,6 +382,8 @@ class BaseChannel
// Won't be set when using raw packet transports. SDP-specific thing.
std::string transport_name_;
+ const bool rtcp_mux_required_;
+
// Separate DTLS/non-DTLS pointers to support using BaseChannel without DTLS.
// Temporary measure until more refactoring is done.
// If non-null, "X_dtls_transport_" will always equal "X_packet_transport_".
@@ -402,8 +395,6 @@ class BaseChannel
SrtpFilter srtp_filter_;
RtcpMuxFilter rtcp_mux_filter_;
BundleFilter bundle_filter_;
- bool rtp_ready_to_send_ = false;
- bool rtcp_ready_to_send_ = false;
bool writable_ = false;
bool was_ever_writable_ = false;
bool has_received_packet_ = false;
« no previous file with comments | « webrtc/pc/BUILD.gn ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698