webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py - Issue 2811953002: APM QA unit tests, fake POLQA binary and minor fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py

Issue 2811953002: APM QA unit tests, fake POLQA binary and minor fixes (Closed)

Patch Set: comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation_unittest.py ('k') | webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py

diff --git a/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py b/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py

index 9f4df941ad6e26f8cdb117debb44ee457f3192d8..76f82e00a97f8dd64aea7bf7137eaa6a8394494a 100644

--- a/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py

+++ b/webrtc/modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py

@@ -297,10 +297,11 @@ class EnvironmentalNoiseTestDataGenerator(TestDataGenerator):

_NOISY_SIGNAL_FILENAME_TEMPLATE = '{0}_{1:d}_SNR.wav'

# TODO(alessiob): allow the user to store the noise tracks in a custom path.

- _NOISE_TRACKS_PATH = os.path.join(os.getcwd(), 'noise_tracks')

+ _NOISE_TRACKS_PATH = os.path.join(

+ os.path.dirname(__file__), os.pardir, 'noise_tracks')

- # TODO(alessiob): allow the user to have custom noise tracks.

- # TODO(alessiob): exploit TestDataGeneratorFactory.GetInstance().

+ # TODO(alessiob): Allow the user to have custom noise tracks.

+ # TODO(alessiob): Exploit TestDataGeneratorFactory.GetInstance().

_NOISE_TRACKS = [

'city.wav'

]

@@ -436,7 +437,7 @@ class ReverberationTestDataGenerator(TestDataGenerator):

# Load noise track.

noise_signal = signal_processing.SignalProcessingUtils.LoadWav(

noise_track_filepath)

- except IOError: # File not found.

+ except exceptions.FileNotFoundError:

# Generate noise track by applying the impulse response.

impulse_response_filepath = os.path.join(

self._aechen_ir_database_path,