Add SafeClamp(), which accepts args of different types

webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc

 /*
  *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/modules/audio_processing/aec3/adaptive_fir_filter.h"
 
 #include <math.h>
 #include <algorithm>
 #include <numeric>
 #include <string>
 #include "webrtc/typedefs.h"
 #if defined(WEBRTC_ARCH_X86_FAMILY)
 #include <emmintrin.h>
 #endif
 #include "webrtc/base/arraysize.h"
 #include "webrtc/base/random.h"
+#include "webrtc/base/safe_minmax.h"
 #include "webrtc/modules/audio_processing/aec3/aec3_fft.h"
 #include "webrtc/modules/audio_processing/aec3/aec_state.h"
 #include "webrtc/modules/audio_processing/aec3/cascaded_biquad_filter.h"
 #include "webrtc/modules/audio_processing/aec3/render_signal_analyzer.h"
 #include "webrtc/modules/audio_processing/aec3/shadow_filter_update_gain.h"
 #include "webrtc/modules/audio_processing/logging/apm_data_dumper.h"
 #include "webrtc/modules/audio_processing/test/echo_canceller_test_tools.h"
 #include "webrtc/system_wrappers/include/cpu_features_wrapper.h"
 #include "webrtc/test/gtest.h"
 
@@ skipping 310 matching lines @@
       x_hp_filter.Process(x[0]);
       y_hp_filter.Process(y);
 
       render_buffer.Insert(x);
       render_signal_analyzer.Update(render_buffer, aec_state.FilterDelay());
 
       filter.Filter(render_buffer, &S);
       fft.Ifft(S, &s);
       std::transform(y.begin(), y.end(), s.begin() + kFftLengthBy2, e.begin(),
                      [&](float a, float b) { return a - b * kScale; });
-      std::for_each(e.begin(), e.end(), [](float& a) {
-        a = std::max(std::min(a, 32767.0f), -32768.0f);
-      });
+      std::for_each(e.begin(), e.end(),
+                    [](float& a) { a = rtc::SafeClamp(a, -32768.f, 32767.f); });
       fft.ZeroPaddedFft(e, &E);
 
       gain.Compute(render_buffer, render_signal_analyzer, E,
                    filter.SizePartitions(), false, &G);
       filter.Adapt(render_buffer, G);
       aec_state.HandleEchoPathChange(EchoPathVariability(false, false));
       aec_state.Update(filter.FilterFrequencyResponse(),
                        rtc::Optional<size_t>(), render_buffer, E2_main, Y2,
                        x[0], false);
     }
     // Verify that the filter is able to perform well.
     EXPECT_LT(1000 * std::inner_product(e.begin(), e.end(), e.begin(), 0.f),
               std::inner_product(y.begin(), y.end(), y.begin(), 0.f));
     ASSERT_TRUE(aec_state.FilterDelay());
     EXPECT_EQ(delay_samples / kBlockSize, *aec_state.FilterDelay());
   }
 }
 }  // namespace aec3
 }  // namespace webrtc