webrtc/modules/audio_processing/test/conversational_speech/timing.cc - Issue 2808053002: Conversational Speech tool completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/test/conversational_speech/timing.cc

Issue 2808053002: Conversational Speech tool completed (Closed)

Patch Set: output for the user added Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_processing/test/conversational_speech/generator.cc ('K') | « webrtc/modules/audio_processing/test/conversational_speech/mock_wavreader.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/test/conversational_speech/timing.cc

diff --git a/webrtc/modules/audio_processing/test/conversational_speech/timing.cc b/webrtc/modules/audio_processing/test/conversational_speech/timing.cc

index 0aa44fa42c864aad43eaa5927297778756b1fe3c..53076f1cacdaf50780b137fb733fb47cc0724625 100644

--- a/webrtc/modules/audio_processing/test/conversational_speech/timing.cc

+++ b/webrtc/modules/audio_processing/test/conversational_speech/timing.cc

@@ -53,7 +53,7 @@ std::vector<Turn> LoadTiming(const std::string& timing_filepath) {

void SaveTiming(const std::string& timing_filepath,

rtc::ArrayView<const Turn> timing) {

std::ofstream outfile(timing_filepath);

- // TODO(alessio): check if file open for writing.

+ RTC_CHECK(outfile.is_open());

for (const Turn& turn : timing) {

outfile << turn.speaker_name << " " << turn.audiotrack_file_name

<< " " << turn.offset << std::endl;