Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: webrtc/sdk/android/api/org/webrtc/PeerConnection.java

Issue 2807933003: Add Java binding for new getStats implementation. (Closed)
Patch Set: Addressing hbos's comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/android/api/org/webrtc/PeerConnection.java
diff --git a/webrtc/sdk/android/api/org/webrtc/PeerConnection.java b/webrtc/sdk/android/api/org/webrtc/PeerConnection.java
index 4e91a1141c8547891cf8d99b4844e058b62332c5..85cb494309790943baf654b038712abd03381d6d 100644
--- a/webrtc/sdk/android/api/org/webrtc/PeerConnection.java
+++ b/webrtc/sdk/android/api/org/webrtc/PeerConnection.java
@@ -265,8 +265,15 @@ public class PeerConnection {
return Collections.unmodifiableList(receivers);
}
+ // Older, non-standard implementation of getStats.
public boolean getStats(StatsObserver observer, MediaStreamTrack track) {
sakal 2017/04/11 12:50:50 Mark with @Deprecated?
Taylor Brandstetter 2017/04/13 02:33:15 Done.
- return nativeGetStats(observer, (track == null) ? 0 : track.nativeTrack);
+ return nativeOldGetStats(observer, (track == null) ? 0 : track.nativeTrack);
+ }
+
+ // Gets stats using the new stats collection API, see webrtc/api/stats/. These
+ // will replace old stats collection API when the new API has matured enough.
+ public void getStats(RTCStatsCollectorCallback callback) {
+ nativeNewGetStats(callback);
}
// Starts recording an RTC event log. Ownership of the file is transfered to
@@ -328,7 +335,9 @@ public class PeerConnection {
private native void nativeRemoveLocalStream(long nativeStream);
- private native boolean nativeGetStats(StatsObserver observer, long nativeTrack);
+ private native boolean nativeOldGetStats(StatsObserver observer, long nativeTrack);
+
+ private native void nativeNewGetStats(RTCStatsCollectorCallback callback);
private native RtpSender nativeCreateSender(String kind, String stream_id);

Powered by Google App Engine
This is Rietveld 408576698