Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Side by Side Diff: webrtc/examples/objc/AppRTCMobile/ARDSettingsModel.h

Issue 2807533004: Address denicija's comments for AppRTCMobile video codec setting. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 * @return YES/NO depending on success. 46 * @return YES/NO depending on success.
47 */ 47 */
48 - (BOOL)storeVideoResolutionSetting:(NSString *)resolution; 48 - (BOOL)storeVideoResolutionSetting:(NSString *)resolution;
49 49
50 /** 50 /**
51 * Returns array of available video codecs. 51 * Returns array of available video codecs.
52 */ 52 */
53 - (NSArray<NSString *> *)availableVideoCodecs; 53 - (NSArray<NSString *> *)availableVideoCodecs;
54 54
55 /** 55 /**
56 * Returns current video codec setting from store if present. 56 * Returns current video codec setting from store if present or default (H264) o therwise.
57 */ 57 */
58 - (NSString *)currentVideoCodecSettingFromStore; 58 - (NSString *)currentVideoCodecSettingFromStore;
59 59
60 /** 60 /**
61 * Stores the provided video codec setting into the store. 61 * Stores the provided video codec setting into the store.
62 * 62 *
63 * If the provided video codec is not part of the available video codecs 63 * If the provided video codec is not part of the available video codecs
64 * the store operation will not be executed and NO will be returned. 64 * the store operation will not be executed and NO will be returned.
65 * @param video codec settings the string to be stored. 65 * @param video codec settings the string to be stored.
66 * @return YES/NO depending on success. 66 * @return YES/NO depending on success.
67 */ 67 */
68 - (BOOL)storeVideoCodecSetting:(NSString *)videoCodec; 68 - (BOOL)storeVideoCodecSetting:(NSString *)videoCodec;
69 69
70 /** 70 /**
71 * Returns current max bitrate setting from store if present. 71 * Returns current max bitrate setting from store if present.
72 */ 72 */
73 - (nullable NSNumber *)currentMaxBitrateSettingFromStore; 73 - (nullable NSNumber *)currentMaxBitrateSettingFromStore;
74 74
75 /** 75 /**
76 * Stores the provided bitrate value into the store. 76 * Stores the provided bitrate value into the store.
77 * 77 *
78 * @param bitrate NSNumber representation of the max bitrate value. 78 * @param bitrate NSNumber representation of the max bitrate value.
79 */ 79 */
80 - (void)storeMaxBitrateSetting:(nullable NSNumber *)bitrate; 80 - (void)storeMaxBitrateSetting:(nullable NSNumber *)bitrate;
81 81
82 @end 82 @end
83 NS_ASSUME_NONNULL_END 83 NS_ASSUME_NONNULL_END
OLDNEW
« no previous file with comments | « no previous file | webrtc/examples/objc/AppRTCMobile/ios/ARDSettingsViewController.m » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698