Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_utility.cc

Issue 2805023002: Add read support of RtpStreamId/RepairedRtpStreamId header extensions. (Closed)
Patch Set: +rtp_header_fuzzer Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtp_utility.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
index def431f1709499993bac608a993aa0c49e33bc1b..6cef43f7251784387290b35a61f3c5dd1097e5d8 100644
--- a/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtp_utility.cc
@@ -446,6 +446,18 @@ void RtpHeaderParser::ParseOneByteExtensionHeader(
max_playout_delay * PlayoutDelayLimits::kGranularityMs;
break;
}
+ case kRtpExtensionRtpStreamId: {
+ RTC_DCHECK_LE(len + 1, sizeof(header->extension.stream_id));
nisse-webrtc 2017/04/10 07:15:27 len+1 here is a bit confusing, but I guess that's
danilchap 2017/04/10 08:39:41 Agree, I'll make a small follow up cl to make len
+ header->extension.stream_id_size = len + 1;
+ memcpy(header->extension.stream_id, ptr, len + 1);
+ break;
+ }
+ case kRtpExtensionRepairedRtpStreamId: {
+ RTC_DCHECK_LE(len + 1, sizeof(header->extension.repaired_stream_id));
+ header->extension.repaired_stream_id_size = len + 1;
+ memcpy(header->extension.repaired_stream_id, ptr, len + 1);
+ break;
+ }
case kRtpExtensionNone:
case kRtpExtensionNumberOfExtensions: {
RTC_NOTREACHED() << "Invalid extension type: " << type;

Powered by Google App Engine
This is Rietveld 408576698