Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: tools-webrtc/android/build_aar.py

Issue 2802693005: Add support for 64-bit architectures in build_aar.py. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools-webrtc/android/build_aar.py
diff --git a/tools-webrtc/android/build_aar.py b/tools-webrtc/android/build_aar.py
index 7d92929eb5d55fb5ed111bb75042fe4324db43dd..9db8f8f2b5010e2b9df4d40152850233f862e854 100755
--- a/tools-webrtc/android/build_aar.py
+++ b/tools-webrtc/android/build_aar.py
@@ -34,7 +34,7 @@ import tempfile
import zipfile
-DEFAULT_ARCHS = ['armeabi-v7a', 'x86']
+DEFAULT_ARCHS = ['armeabi-v7a', 'arm64-v8a', 'x86', 'x86_64']
NEEDED_SO_FILES = ['libjingle_peerconnection_so.so']
JAR_FILE = 'lib.java/webrtc/sdk/android/libwebrtc.jar'
MANIFEST_FILE = 'webrtc/sdk/android/AndroidManifest.xml'
@@ -92,8 +92,12 @@ def _GetTargetCpu(arch):
"""Returns target_cpu for the GN build with the given architecture."""
if arch in ['armeabi', 'armeabi-v7a']:
return 'arm'
+ elif arch == 'arm64-v8a':
+ return 'arm64'
elif arch == 'x86':
return 'x86'
+ elif arch == 'x86_64':
+ return 'x64'
else:
raise Exception('Unknown arch: ' + arch)
@@ -104,7 +108,7 @@ def _GetArmVersion(arch):
return 6
elif arch == 'armeabi-v7a':
return 7
- elif arch == 'x86':
+ elif arch in ['arm64-v8a', 'x86', 'x86_64']:
return None
else:
raise Exception('Unknown arch: ' + arch)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698