webrtc/modules/congestion_controller/include/send_side_congestion_controller.h - Issue 2795643002: Add methods to register congestion controller observer after construction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

Issue 2795643002: Add methods to register congestion controller observer after construction. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | webrtc/modules/congestion_controller/send_side_congestion_controller.cc » ('j') | webrtc/modules/congestion_controller/send_side_congestion_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

diff --git a/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h b/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

index 8130feb01e2f02a8c43e8227a06052db1babfa92..5849ee82a8cdc72bd1b0877656f47f27f5ea8041 100644

--- a/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

+++ b/webrtc/modules/congestion_controller/include/send_side_congestion_controller.h

@@ -70,6 +70,10 @@ class SendSideCongestionController : public CallStatsObserver,

void RegisterPacketFeedbackObserver(PacketFeedbackObserver* observer);

void DeRegisterPacketFeedbackObserver(PacketFeedbackObserver* observer);

+ // Currently, there can be at most one observer.

+ void RegisterNetworkObserver(Observer* observer);

+ void DeRegisterNetworkObserver(Observer* observer);

virtual void SetBweBitrates(int min_bitrate_bps,

int start_bitrate_bps,

int max_bitrate_bps);

@@ -130,7 +134,8 @@ class SendSideCongestionController : public CallStatsObserver,

uint8_t fraction_loss,

int64_t rtt);

const Clock* const clock_;

- Observer* const observer_;

+ rtc::CriticalSection observer_lock_;

+ Observer* observer_ GUARDED_BY(observer_lock_);

RtcEventLog* const event_log_;

const std::unique_ptr<PacedSender> pacer_;

const std::unique_ptr<BitrateController> bitrate_controller_;