Add PeerConnectionInterface::UpdateCallBitrate.

webrtc/call/call.h

Index: webrtc/call/call.h
diff --git a/webrtc/call/call.h b/webrtc/call/call.h
index ec73bf7714926b2a6b04210f3c66a881f9acbedf..de2e1764f42877ea82b8de9cccbb4cfe4c6883ec 100644
--- a/webrtc/call/call.h
+++ b/webrtc/call/call.h
@@ -75,6 +75,12 @@ class Call {
       int max_bitrate_bps = -1;
     } bitrate_config;
 
+    struct BitrateConfigMask {
+      rtc::Optional<int> min_bitrate_bps;
+      rtc::Optional<int> start_bitrate_bps;
+      rtc::Optional<int> max_bitrate_bps;
+    };

[Taylor Brandstetter, 2017/04/07 03:29:12]

Couldn't one struct be used by both PeerConnection and Call?

[Zach Stein, 2017/04/09 21:09:01]

I did it this way because I wasn't sure where that struct should go.

I am assuming that Call is an implementation detail of PeerConnection, so
PeerConnectionInterface should not depend on Call and Call should not depend on
PeerConnectionInterface. The struct could go in base instead, so that both could
depend on it, but that seemed like overkill to me (I'm not sure this struct is
generally useful enough to be in base). The high-level dependency structure is
still pretty fuzzy to me though, so let me know what you think!

[Taylor Brandstetter, 2017/04/10 04:59:51]

PeerConnectionInterface (being the "public interface") shouldn't depend on Call,
but Call can depend on things in the public interface. So I'd move BitrateConfig
to some header file in api/ (either peerconnectioninterface.h, or something else
that makes sense). Maybe it's overkill, but I prefer cutting down on duplicated
structures/classes; we already have a lot of them.

[stefan-webrtc, 2017/04/10 13:26:58]

But will we not want to have this also for ORTC at some point? In that case I
wouldn't expect ORTC to include peerconnectioninterface.h? 

Also, I think there are tests in other repositories that build on Call instead
of PeerConnection to be more light weight.

+
     // AudioState which is possibly shared between multiple calls.
     // TODO(solenberg): Change this to a shared_ptr once we can use C++11.
     rtc::scoped_refptr<AudioState> audio_state;
@@ -144,6 +150,8 @@ class Call {
   virtual void SetBitrateConfig(
       const Config::BitrateConfig& bitrate_config) = 0;
 
+  virtual void UpdateBitrateConfig(const Config::BitrateConfigMask& mask) = 0;
+
   // TODO(skvlad): When the unbundled case with multiple streams for the same
   // media type going over different networks is supported, track the state
   // for each stream separately. Right now it's global per media type.