Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: webrtc/pc/peerconnectioninterface_unittest.cc

Issue 2793913008: Add PeerConnectionInterface::UpdateCallBitrate. (Closed)
Patch Set: move start DCHECK in SetBitrateConfig with other DCHECKs Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/pc/peerconnection.cc ('K') | « webrtc/pc/peerconnection.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/peerconnectioninterface_unittest.cc
diff --git a/webrtc/pc/peerconnectioninterface_unittest.cc b/webrtc/pc/peerconnectioninterface_unittest.cc
index 05d53ad1a153fdcacc66f240d706c88f69d51f64..6f123aec3bd8a4138cbddd075be48309903f1e2c 100644
--- a/webrtc/pc/peerconnectioninterface_unittest.cc
+++ b/webrtc/pc/peerconnectioninterface_unittest.cc
@@ -3286,6 +3286,18 @@ TEST_F(PeerConnectionInterfaceTest,
EXPECT_TRUE(DoSetLocalDescription(answer.release()));
}
+TEST_F(PeerConnectionInterfaceTest, SetBitrateWithoutMinSucceeds) {
+ CreatePeerConnection();
+ PeerConnectionInterface::BitrateParameters bitrate;
+ bitrate.current_bitrate_bps = rtc::Optional<int>(100000);
+ // Call doesn't expose its current config, so we just check that the
+ // method invocation succeeds here.
+ pc_->SetBitrate(bitrate);
+}
Taylor Brandstetter 2017/04/19 01:06:54 Can you add a basic test for the errors?
Zach Stein 2017/04/20 20:48:00 Done.
+
+// TODO(zstein): More exhaustive tests of
+// PeerConnectionInterface::SetCallBitrate
+
class PeerConnectionMediaConfigTest : public testing::Test {
protected:
void SetUp() override {
« webrtc/pc/peerconnection.cc ('K') | « webrtc/pc/peerconnection.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698