Chromium Code Reviews

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2793913008: Add PeerConnectionInterface::UpdateCallBitrate. (Closed)
Patch Set: minor fixes - still 2 todos in call Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index e96545736257bdbd25b27715bf48c828926d4dcb..31d8ca18a77a969566929449a41f2bd63243c427 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -728,6 +728,18 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// destroyed, RegisterUMAOberver(nullptr) should be called.
virtual void RegisterUMAObserver(UMAObserver* observer) = 0;
+ // The implementation is free to choose whatever values it wants for unset
+ // parameters. 0 <= min <= start <= max should hold for set parameters.
+ // Changing start will reset the current bitrate estimate.
Taylor Brandstetter 2017/04/13 22:16:13 nit: I'd still prefer a more thorough description.
+ struct BitrateParameters {
+ rtc::Optional<int> min_bitrate_bps;
+ rtc::Optional<int> start_bitrate_bps;
Taylor Brandstetter 2017/04/13 22:16:13 While writing the above description, I was reminde
Zach Stein 2017/04/18 22:54:50 I like current better than start, but I would pref
Taylor Brandstetter 2017/04/19 01:06:53 When you say you'd prefer not changing SetBweBitra
Zach Stein 2017/04/20 20:48:00 Looking at SetBweBitrates again, I think it actual
+ rtc::Optional<int> max_bitrate_bps;
+ };
+
+ // Sets bitrate parameters for the entire connection.
+ virtual void SetBitrate(const BitrateParameters& bitrate) = 0;
Taylor Brandstetter 2017/04/13 22:16:13 nit: "SetBitrateParameters"?
+
// Returns the current SignalingState.
virtual SignalingState signaling_state() = 0;
virtual IceConnectionState ice_connection_state() = 0;
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | no next file with comments »

Powered by Google App Engine