Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1902)

Unified Diff: webrtc/api/peerconnectioninterface.h

Issue 2793913008: Add PeerConnectionInterface::UpdateCallBitrate. (Closed)
Patch Set: add a todo about de-duplicating bitrate mask structs Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/call.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/peerconnectioninterface.h
diff --git a/webrtc/api/peerconnectioninterface.h b/webrtc/api/peerconnectioninterface.h
index e96545736257bdbd25b27715bf48c828926d4dcb..07770b24c097dfb1b6423d59f64a1fe379c292b7 100644
--- a/webrtc/api/peerconnectioninterface.h
+++ b/webrtc/api/peerconnectioninterface.h
@@ -728,6 +728,16 @@ class PeerConnectionInterface : public rtc::RefCountInterface {
// destroyed, RegisterUMAOberver(nullptr) should be called.
virtual void RegisterUMAObserver(UMAObserver* observer) = 0;
+ // Parameters that are not set will defer to implementation defined values.
Taylor Brandstetter 2017/04/12 01:33:41 "or values from x-google-[min/start/max]-bitrate,
Zach Stein 2017/04/13 00:26:36 I was being intentionally vague to avoid this gett
Taylor Brandstetter 2017/04/13 22:16:13 If you were being intentionally vague, "implementa
+ struct BitrateParameters {
+ rtc::Optional<int> min_bitrate_bps;
+ rtc::Optional<int> start_bitrate_bps;
+ rtc::Optional<int> max_bitrate_bps;
Taylor Brandstetter 2017/04/12 01:33:41 I think it's worth describing the behavior of min/
Zach Stein 2017/04/13 00:26:36 Done.
+ };
+
+ // Updates the Call level bitrate parameters.
Taylor Brandstetter 2017/04/12 01:33:41 I wouldn't say "Call level", since someone just us
Zach Stein 2017/04/13 00:26:36 Done.
+ virtual void SetCallBitrate(const BitrateParameters& bitrate) = 0;
+
// Returns the current SignalingState.
virtual SignalingState signaling_state() = 0;
virtual IceConnectionState ice_connection_state() = 0;
« no previous file with comments | « no previous file | webrtc/api/peerconnectionproxy.h » ('j') | webrtc/call/call.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698