Add PeerConnectionInterface::UpdateCallBitrate.

webrtc/pc/peerconnection.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 1217 matching lines @@
           kEnumCounterAddressFamily, kPeerConnection_IPv6,
           kPeerConnectionAddressFamilyCounter_Max);
     } else {
       uma_observer_->IncrementEnumCounter(
           kEnumCounterAddressFamily, kPeerConnection_IPv4,
           kPeerConnectionAddressFamilyCounter_Max);
     }
   }
 }
 
+RTCError PeerConnection::SetBitrate(const BitrateParameters& bitrate) {
+  return factory_->worker_thread()->Invoke<RTCError>(

[Taylor Brandstetter, 2017/04/19 01:06:54]

To avoid the extra indentation, and because the chromium style guide prohibits
storing capturing lambdas, could this be changed to:

if (!factory_->worker_thread()->IsCurrent()) {
  return factory_->worker_thread()->Invoke<RTCError>(
      RTC_FROM_HERE, rtc::Bind(&PeerConnection::SetBitrate, this, bitrate));
}
// rest of stuff

[Zach Stein, 2017/04/20 20:48:00]

Done.

+      RTC_FROM_HERE, [this, &bitrate]() {
+        const bool has_min = static_cast<bool>(bitrate.min_bitrate_bps);
+        const bool has_current = static_cast<bool>(bitrate.current_bitrate_bps);
+        const bool has_max = static_cast<bool>(bitrate.max_bitrate_bps);
+        if (has_min && *bitrate.min_bitrate_bps <= 0) {

[Taylor Brandstetter, 2017/04/19 01:06:54]

Isn't "min == 0" ok?

[Zach Stein, 2017/04/20 20:48:00]

This makes setting all of the parameters to 0 legal, but I doubt this matters
much in practice (the values will be clamped to higher values in at least one
place later on).

+          return RTCError(RTCErrorType::INVALID_PARAMETER,

[Taylor Brandstetter, 2017/04/19 01:06:54]

Can you use the "RETURN_AND_LOG_ERROR" macro, so that these errors will appear
in the log as well?

[Zach Stein, 2017/04/20 20:48:00]

Done.

+                          "min_bitrate_bps <= 0");
+        }
+        if (has_current) {
+          if (has_min &&
+              *bitrate.current_bitrate_bps < *bitrate.min_bitrate_bps) {
+            return RTCError(RTCErrorType::INVALID_PARAMETER,
+                            "current_bitrate_bps < min_bitrate_bps");
+          } else if (*bitrate.current_bitrate_bps < 0) {
+            return RTCError(RTCErrorType::INVALID_PARAMETER,
+                            "curent_bitrate_bps < 0");
+          }
+        }
+        if (has_max) {
+          if (has_current &&
+              *bitrate.max_bitrate_bps < *bitrate.current_bitrate_bps) {
+            return RTCError(RTCErrorType::INVALID_PARAMETER,
+                            "max_bitrate_bps < current_bitrate_bps");
+          } else if (has_min &&
+                     *bitrate.max_bitrate_bps < *bitrate.min_bitrate_bps) {
+            return RTCError(RTCErrorType::INVALID_PARAMETER,
+                            "max_bitrate_bps < min_bitrate_bps");
+          } else if (*bitrate.max_bitrate_bps < 0) {
+            return RTCError(RTCErrorType::INVALID_PARAMETER,
+                            "max_bitrate_bps < 0");
+          }
+        }
+
+        Call::Config::BitrateConfigMask mask;
+        mask.min_bitrate_bps = bitrate.min_bitrate_bps;
+        mask.start_bitrate_bps = bitrate.current_bitrate_bps;
+        mask.max_bitrate_bps = bitrate.max_bitrate_bps;
+
+        RTC_DCHECK(media_controller_);
+        Call* call = media_controller_->call_w();
+        call->SetBitrateConfigMask(mask);
+
+        return RTCError::OK();
+      });
+}
+
 bool PeerConnection::StartRtcEventLog(rtc::PlatformFile file,
                                       int64_t max_size_bytes) {
   return factory_->worker_thread()->Invoke<bool>(
       RTC_FROM_HERE, rtc::Bind(&PeerConnection::StartRtcEventLog_w, this, file,
                                max_size_bytes));
 }
 
 void PeerConnection::StopRtcEventLog() {
   factory_->worker_thread()->Invoke<void>(
       RTC_FROM_HERE, rtc::Bind(&PeerConnection::StopRtcEventLog_w, this));
@@ skipping 1060 matching lines @@
   }
   return event_log_->StartLogging(file, max_size_bytes);
 }
 
 void PeerConnection::StopRtcEventLog_w() {
   if (event_log_) {
     event_log_->StopLogging();
   }
 }
 }  // namespace webrtc