OLD | NEW |
---|---|
1 /* | 1 /* |
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. | 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. |
3 * | 3 * |
4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
9 */ | 9 */ |
10 | 10 |
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
721 const std::vector<cricket::Candidate>& candidates) { | 721 const std::vector<cricket::Candidate>& candidates) { |
722 return false; | 722 return false; |
723 } | 723 } |
724 | 724 |
725 // Register a metric observer (used by chromium). | 725 // Register a metric observer (used by chromium). |
726 // | 726 // |
727 // There can only be one observer at a time. Before the observer is | 727 // There can only be one observer at a time. Before the observer is |
728 // destroyed, RegisterUMAOberver(nullptr) should be called. | 728 // destroyed, RegisterUMAOberver(nullptr) should be called. |
729 virtual void RegisterUMAObserver(UMAObserver* observer) = 0; | 729 virtual void RegisterUMAObserver(UMAObserver* observer) = 0; |
730 | 730 |
731 // The implementation is free to choose whatever values it wants for unset | |
732 // parameters. 0 <= min <= start <= max should hold for set parameters. | |
733 // Changing start will reset the current bitrate estimate. | |
Taylor Brandstetter
2017/04/13 22:16:13
nit: I'd still prefer a more thorough description.
| |
734 struct BitrateParameters { | |
735 rtc::Optional<int> min_bitrate_bps; | |
736 rtc::Optional<int> start_bitrate_bps; | |
Taylor Brandstetter
2017/04/13 22:16:13
While writing the above description, I was reminde
Zach Stein
2017/04/18 22:54:50
I like current better than start, but I would pref
Taylor Brandstetter
2017/04/19 01:06:53
When you say you'd prefer not changing SetBweBitra
Zach Stein
2017/04/20 20:48:00
Looking at SetBweBitrates again, I think it actual
| |
737 rtc::Optional<int> max_bitrate_bps; | |
738 }; | |
739 | |
740 // Sets bitrate parameters for the entire connection. | |
741 virtual void SetBitrate(const BitrateParameters& bitrate) = 0; | |
Taylor Brandstetter
2017/04/13 22:16:13
nit: "SetBitrateParameters"?
| |
742 | |
731 // Returns the current SignalingState. | 743 // Returns the current SignalingState. |
732 virtual SignalingState signaling_state() = 0; | 744 virtual SignalingState signaling_state() = 0; |
733 virtual IceConnectionState ice_connection_state() = 0; | 745 virtual IceConnectionState ice_connection_state() = 0; |
734 virtual IceGatheringState ice_gathering_state() = 0; | 746 virtual IceGatheringState ice_gathering_state() = 0; |
735 | 747 |
736 // Starts RtcEventLog using existing file. Takes ownership of |file| and | 748 // Starts RtcEventLog using existing file. Takes ownership of |file| and |
737 // passes it on to Call, which will take the ownership. If the | 749 // passes it on to Call, which will take the ownership. If the |
738 // operation fails the file will be closed. The logging will stop | 750 // operation fails the file will be closed. The logging will stop |
739 // automatically after 10 minutes have passed, or when the StopRtcEventLog | 751 // automatically after 10 minutes have passed, or when the StopRtcEventLog |
740 // function is called. | 752 // function is called. |
(...skipping 357 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
1098 cricket::WebRtcVideoEncoderFactory* encoder_factory, | 1110 cricket::WebRtcVideoEncoderFactory* encoder_factory, |
1099 cricket::WebRtcVideoDecoderFactory* decoder_factory) { | 1111 cricket::WebRtcVideoDecoderFactory* decoder_factory) { |
1100 return CreatePeerConnectionFactory( | 1112 return CreatePeerConnectionFactory( |
1101 worker_and_network_thread, worker_and_network_thread, signaling_thread, | 1113 worker_and_network_thread, worker_and_network_thread, signaling_thread, |
1102 default_adm, encoder_factory, decoder_factory); | 1114 default_adm, encoder_factory, decoder_factory); |
1103 } | 1115 } |
1104 | 1116 |
1105 } // namespace webrtc | 1117 } // namespace webrtc |
1106 | 1118 |
1107 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ | 1119 #endif // WEBRTC_API_PEERCONNECTIONINTERFACE_H_ |
OLD | NEW |