Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: webrtc/pc/rtptransport.h

Issue 2792223002: Add a minimal RtpTransport class for use by BaseChannel. (Closed)
Patch Set: removing a comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtptransport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/rtptransport.h
diff --git a/webrtc/pc/rtptransport.h b/webrtc/pc/rtptransport.h
new file mode 100644
index 0000000000000000000000000000000000000000..6febd8624db63f300943705166d1440178572d8a
--- /dev/null
+++ b/webrtc/pc/rtptransport.h
@@ -0,0 +1,57 @@
+/*
+ * Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_PC_RTPTRANSPORT_H_
+#define WEBRTC_PC_RTPTRANSPORT_H_
+
+namespace rtc {
+
+class PacketTransportInternal;
+
+} // namespace rtc
+
+namespace webrtc {
+
+class RtpTransport {
+ public:
+ RtpTransport(const RtpTransport&) = delete;
+ RtpTransport& operator=(const RtpTransport&) = delete;
+
+ explicit RtpTransport(bool rtcp_mux_required)
Taylor_Brandstetter 2017/04/04 16:47:32 I think it would make sense for the constructor to
+ : rtcp_mux_required_(rtcp_mux_required) {}
+
+ bool rtcp_mux_required() const { return rtcp_mux_required_; }
+
+ rtc::PacketTransportInternal* rtp_packet_transport() const {
+ return rtp_packet_transport_;
+ }
+ void set_rtp_packet_transport(rtc::PacketTransportInternal* rtp) {
+ rtp_packet_transport_ = rtp;
+ }
+
+ rtc::PacketTransportInternal* rtcp_packet_transport() const {
+ return rtcp_packet_transport_;
+ }
+ void set_rtcp_packet_transport(rtc::PacketTransportInternal* rtcp);
+
+ private:
+ // True if RTCP-multiplexing is required. rtcp_packet_transport_ should
+ // always be null in this case.
+ const bool rtcp_mux_required_;
+
+ // TODO(zstein): These should probably be owned here - they are currently
+ // owned by TransportController
Taylor_Brandstetter 2017/04/04 16:47:32 I'm not so sure about this TODO. The current owner
+ rtc::PacketTransportInternal* rtp_packet_transport_ = nullptr;
+ rtc::PacketTransportInternal* rtcp_packet_transport_ = nullptr;
+};
+
+} // namespace webrtc
+
+#endif // WEBRTC_PC_RTPTRANSPORT_H_
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtptransport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698