Conversational speech tool, simualtor + unit tests

webrtc/modules/audio_processing/test/conversational_speech/simulator.h

+/*
+ *  Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_SIMULATOR_H_
+#define WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_SIMULATOR_H_
+
+#include <map>
+#include <memory>
+#include <string>
+#include <utility>
+
+#include "webrtc/base/constructormagic.h"
+#include "webrtc/modules/audio_processing/test/conversational_speech/multiend_call.h"
+
+namespace webrtc {
+namespace test {
+namespace conversational_speech {
+
+struct SpeakerOutputFilePaths {
+  SpeakerOutputFilePaths(std::string new_near_end,
+                         std::string new_far_end)
+      : near_end(std::move(new_near_end)),

[minyue-webrtc, 2017/04/07 13:24:31]

no need for "move"

[AleBzk, 2017/04/10 08:24:49]

Well, last week Henrik, Karl and I came across this point.
See here:
https://codereview.webrtc.org/2781573002/diff/130001/webrtc/modules/audio_pro...
We ended up to using std::move to have one copy and one move instead of two
copies. This is apparently a good solution when using emplace operations from
the standard library - which is the case.

Let's discuss this offline if needed.

+        far_end(std::move(new_far_end)) {}
+  // Paths to the near-end and far-end audio track files.
+  std::string near_end;

[minyue-webrtc, 2017/04/07 13:24:31]

can add const

[AleBzk, 2017/04/10 08:24:48]

Done.

+  std::string far_end;

[minyue-webrtc, 2017/04/07 13:24:31]

can add const

[AleBzk, 2017/04/10 08:24:48]

Done.

+
+  // RTC_DISALLOW_COPY_AND_ASSIGN(SpeakerOutputFilePaths);

[minyue-webrtc, 2017/04/07 13:24:31]

why commented out

[AleBzk, 2017/04/10 08:24:48]

Sorry, "leftover". Don't need it anymore.

+};
+
+// Generates the near-end and far-end audio track pairs for each speaker.
+std::unique_ptr<std::map<std::string, SpeakerOutputFilePaths>>
+    Simulate(const MultiEndCall& multiend_call, const std::string& output_path);
+
+}  // namespace conversational_speech
+}  // namespace test
+}  // namespace webrtc
+
+#endif  // WEBRTC_MODULES_AUDIO_PROCESSING_TEST_CONVERSATIONAL_SPEECH_SIMULATOR_H_