Supporting 48kHz PCM file.

Supporting 48kHz PCM file.

BUG=None

Review-Url: https://codereview.webrtc.org/2790493004
Cr-Commit-Position: refs/heads/master@{#17493}
Committed: https://chromium.googlesource.com/external/webrtc/+/5f93709e7c65faa9616f09368a92d47087b778f5

[minyue-webrtc, 2017-03-31 09:09:45]

Description was changed from

==========
Supporting 48kHz PCM file.

BUG=None
==========

to

==========
Supporting 48kHz PCM file.

BUG=None
==========

[minyue-webrtc, 2017-03-31 09:09:46]

minyue@webrtc.org changed reviewers:
+ niklas.enbom@webrtc.org

[minyue-webrtc, 2017-03-31 09:10:31]

minyue@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[minyue-webrtc, 2017-03-31 09:11:49]

I saw that the support of 48kHz PCM file was missing at various places. PTAL
this CL.

[the sun, 2017-03-31 10:26:18]

https://codereview.webrtc.org/2790493004/diff/1/webrtc/voice_engine/file_play...
File webrtc/voice_engine/file_player.h (left):

https://codereview.webrtc.org/2790493004/diff/1/webrtc/voice_engine/file_play...
webrtc/voice_engine/file_player.h:26: // The largest decoded frame size in
samples (60ms with 32kHz sample rate).
Note that VoE file playing functionality is going to be remove really soon. What
is the use case of the changes in this CL?

[the sun, 2017-03-31 10:28:26]

lgtm

[minyue-webrtc, 2017-03-31 10:47:31]

https://codereview.webrtc.org/2790493004/diff/1/webrtc/voice_engine/file_play...
File webrtc/voice_engine/file_player.h (left):

https://codereview.webrtc.org/2790493004/diff/1/webrtc/voice_engine/file_play...
webrtc/voice_engine/file_player.h:26: // The largest decoded frame size in
samples (60ms with 32kHz sample rate).
On 2017/03/31 10:26:18, the sun wrote:
> Note that VoE file playing functionality is going to be remove really soon.
What
> is the use case of the changes in this CL?

I use it for a little project by myself. So I don't mind not checking in voe
related changes. But if future changes need FilePlayer as a reference, it is
good to fix it.

[niklas.enbom, 2017-03-31 16:01:25]

lgtm
On 2017/03/31 10:47:31, minyue-webrtc wrote:
>
https://codereview.webrtc.org/2790493004/diff/1/webrtc/voice_engine/file_play...
> File webrtc/voice_engine/file_player.h (left):
> 
>
https://codereview.webrtc.org/2790493004/diff/1/webrtc/voice_engine/file_play...
> webrtc/voice_engine/file_player.h:26: // The largest decoded frame size in
> samples (60ms with 32kHz sample rate).
> On 2017/03/31 10:26:18, the sun wrote:
> > Note that VoE file playing functionality is going to be remove really soon.
> What
> > is the use case of the changes in this CL?
> 
> I use it for a little project by myself. So I don't mind not checking in voe
> related changes. But if future changes need FilePlayer as a reference, it is
> good to fix it.

[minyue-webrtc, 2017-03-31 18:59:16]

The CQ bit was checked by minyue@webrtc.org

[commit-bot: I haz the power, 2017-03-31 18:59:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-31 19:27:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490986756552750, "parent_rev":
"16d5bae3963950082447dad230f827a134f0cc68", "commit_rev":
"5f93709e7c65faa9616f09368a92d47087b778f5"}

[commit-bot: I haz the power, 2017-03-31 19:27:13]

Description was changed from

==========
Supporting 48kHz PCM file.

BUG=None
==========

to

==========
Supporting 48kHz PCM file.

BUG=None

Review-Url: https://codereview.webrtc.org/2790493004
Cr-Commit-Position: refs/heads/master@{#17493}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5f93709e7c65faa9616f09368...
==========

[commit-bot: I haz the power, 2017-03-31 19:27:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5f93709e7c65faa9616f09368...

[lliuu, 2017-03-31 23:32:15]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2791453004/ by lliuu@webrtc.org.

The reason for reverting is: broke internal project.