Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: webrtc/video/rtp_stream_receiver.cc

Issue 2789843002: Delete VieRemb class, move functionality to PacketRouter. (Closed)
Patch Set: Rewrote OnReceivedPacketWithAbsSendTime test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/rtp_stream_receiver.cc
diff --git a/webrtc/video/rtp_stream_receiver.cc b/webrtc/video/rtp_stream_receiver.cc
index 90dd0da0e1cda44c4e130aa6ef55fef9303f7b9b..8516eb966f434a87506ebf69de22a072d82b348c 100644
--- a/webrtc/video/rtp_stream_receiver.cc
+++ b/webrtc/video/rtp_stream_receiver.cc
@@ -38,7 +38,6 @@
#include "webrtc/system_wrappers/include/metrics.h"
#include "webrtc/system_wrappers/include/timestamp_extrapolator.h"
#include "webrtc/video/receive_statistics_proxy.h"
-#include "webrtc/video/vie_remb.h"
namespace webrtc {
@@ -83,7 +82,6 @@ RtpStreamReceiver::RtpStreamReceiver(
Transport* transport,
RtcpRttStats* rtt_stats,
PacketRouter* packet_router,
- VieRemb* remb,
const VideoReceiveStream::Config* config,
ReceiveStatisticsProxy* receive_stats_proxy,
ProcessThread* process_thread,
@@ -94,7 +92,6 @@ RtpStreamReceiver::RtpStreamReceiver(
: clock_(Clock::GetRealTimeClock()),
config_(*config),
packet_router_(packet_router),
- remb_(remb),
process_thread_(process_thread),
ntp_estimator_(clock_),
rtp_header_parser_(RtpHeaderParser::Create()),
@@ -132,7 +129,6 @@ RtpStreamReceiver::RtpStreamReceiver(
rtp_rtcp_->SetKeyFrameRequestMethod(kKeyFrameReqPliRtcp);
if (config_.rtp.remb) {
rtp_rtcp_->SetREMBStatus(true);
- remb_->AddReceiveChannel(rtp_rtcp_.get());
}
for (size_t i = 0; i < config_.rtp.extensions.size(); ++i) {
@@ -204,9 +200,6 @@ RtpStreamReceiver::~RtpStreamReceiver() {
packet_router_->RemoveReceiveRtpModule(rtp_rtcp_.get());
rtp_rtcp_->SetREMBStatus(false);
- if (config_.rtp.remb) {
- remb_->RemoveReceiveChannel(rtp_rtcp_.get());
- }
UpdateHistograms();
}

Powered by Google App Engine
This is Rietveld 408576698