Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Unified Diff: webrtc/call/call.cc

Issue 2789843002: Delete VieRemb class, move functionality to PacketRouter. (Closed)
Patch Set: Rewrote OnReceivedPacketWithAbsSendTime test. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/call.cc
diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc
index e9838d9baad0acdadde8f33ddc12bb863068cc92..04b860beb03b685a18a2260e6304e7429eec35ca 100644
--- a/webrtc/call/call.cc
+++ b/webrtc/call/call.cc
@@ -56,7 +56,6 @@
#include "webrtc/video/stats_counter.h"
#include "webrtc/video/video_receive_stream.h"
#include "webrtc/video/video_send_stream.h"
-#include "webrtc/video/vie_remb.h"
namespace webrtc {
@@ -311,7 +310,6 @@ class Call : public webrtc::Call,
std::map<std::string, rtc::NetworkRoute> network_routes_;
std::unique_ptr<RtpTransportControllerSend> transport_send_;
- VieRemb remb_;
ReceiveSideCongestionController receive_side_cc_;
const std::unique_ptr<SendDelayStats> video_send_delay_stats_;
const int64_t start_ms_;
@@ -370,8 +368,7 @@ Call::Call(const Call::Config& config,
estimated_send_bitrate_kbps_counter_(clock_, nullptr, true),
pacer_bitrate_kbps_counter_(clock_, nullptr, true),
transport_send_(std::move(transport_send)),
- remb_(clock_),
- receive_side_cc_(clock_, &remb_, transport_send_->packet_router()),
+ receive_side_cc_(clock_, transport_send_->packet_router()),
video_send_delay_stats_(new SendDelayStats(clock_)),
start_ms_(clock_->TimeInMilliseconds()),
worker_queue_("call_worker_queue") {
@@ -408,7 +405,6 @@ Call::Call(const Call::Config& config,
}
Call::~Call() {
- RTC_DCHECK(!remb_.InUse());
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
RTC_CHECK(audio_send_ssrcs_.empty());
@@ -667,7 +663,7 @@ webrtc::VideoSendStream* Call::CreateVideoSendStream(
VideoSendStream* send_stream = new VideoSendStream(
num_cpu_cores_, module_process_thread_.get(), &worker_queue_,
call_stats_.get(), transport_send_.get(), bitrate_allocator_.get(),
- video_send_delay_stats_.get(), &remb_, event_log_, std::move(config),
+ video_send_delay_stats_.get(), event_log_, std::move(config),
std::move(encoder_config), suspended_video_send_ssrcs_);
{
@@ -724,10 +720,10 @@ webrtc::VideoReceiveStream* Call::CreateVideoReceiveStream(
TRACE_EVENT0("webrtc", "Call::CreateVideoReceiveStream");
RTC_DCHECK(configuration_thread_checker_.CalledOnValidThread());
- VideoReceiveStream* receive_stream = new VideoReceiveStream(
- num_cpu_cores_, transport_send_->packet_router(),
- std::move(configuration), module_process_thread_.get(), call_stats_.get(),
- &remb_);
+ VideoReceiveStream* receive_stream =
+ new VideoReceiveStream(num_cpu_cores_, transport_send_->packet_router(),
+ std::move(configuration),
+ module_process_thread_.get(), call_stats_.get());
const webrtc::VideoReceiveStream::Config& config = receive_stream->config();
ReceiveRtpConfig receive_config(config.rtp.extensions,

Powered by Google App Engine
This is Rietveld 408576698