Chromium Code Reviews| Index: webrtc/video_receive_stream.h |
| diff --git a/webrtc/video_receive_stream.h b/webrtc/video_receive_stream.h |
| index 33d779d9b39444ab09a53d8457e879034dcf41f2..b3a98c617ac2ebc120bf50f557faf537af47ba52 100644 |
| --- a/webrtc/video_receive_stream.h |
| +++ b/webrtc/video_receive_stream.h |
| @@ -132,6 +132,15 @@ class VideoReceiveStream { |
| bool receiver_reference_time_report = false; |
| } rtcp_xr; |
| + // TODO(nisse): This remb setting is currently set but never |
| + // applied. REMB logic is now the responsibility of |
| + // PacketRouter, and it will generate REMB feedback if |
| + // OnReceiveBitrateChanged is used, which depends on how the |
| + // estimators belonging to the ReceiveSideCongestionController |
| + // are configured. Decide if this setting should be deleted, and |
| + // if it needs to be replaced by a setting in PacketRouter to |
| + // disable REMB feedback. |
|
stefan-webrtc
2017/04/11 09:28:36
This would be important if there are no other ways
nisse-webrtc
2017/04/11 10:57:41
As far as I understand, if there are no abs-send-t
|
| + |
| // See draft-alvestrand-rmcat-remb for information. |
| bool remb = false; |