Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: webrtc/modules/pacing/packet_router.cc

Issue 2789843002: Delete VieRemb class, move functionality to PacketRouter. (Closed)
Patch Set: New method PacketRouter::SendRemb. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/pacing/packet_router.cc
diff --git a/webrtc/modules/pacing/packet_router.cc b/webrtc/modules/pacing/packet_router.cc
index ab86bfa4bd82551f8014cd5652540e743577ce8d..d341b444a7825a935ba0ea20604717903a4c84c1 100644
--- a/webrtc/modules/pacing/packet_router.cc
+++ b/webrtc/modules/pacing/packet_router.cc
@@ -12,6 +12,7 @@
#include "webrtc/base/atomicops.h"
#include "webrtc/base/checks.h"
+#include "webrtc/base/timeutils.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp.h"
#include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h"
@@ -121,7 +122,60 @@ uint16_t PacketRouter::AllocateSequenceNumber() {
return new_seq;
}
-bool PacketRouter::SendFeedback(rtcp::TransportFeedback* packet) {
+void PacketRouter::OnReceiveBitrateChanged(const std::vector<uint32_t>& ssrcs,
+ uint32_t bitrate_bps) {
+ const int kRembSendIntervalMs = 200;
+
+ // % threshold for if we should send a new REMB asap.
+ const uint32_t kSendThresholdPercent = 97;
+
+ int64_t now_ms = rtc::TimeMillis();
+ {
+ rtc::CritScope lock(&remb_crit_);
+
+ // If we already have an estimate, check if the new total estimate is below
+ // kSendThresholdPercent of the previous estimate.
+ if (last_send_bitrate_bps_ > 0) {
+ uint32_t new_remb_bitrate_bps =
+ last_send_bitrate_bps_ - bitrate_bps_ + bitrate_bps;
+
+ if (new_remb_bitrate_bps <
+ kSendThresholdPercent * last_send_bitrate_bps_ / 100) {
+ // The new bitrate estimate is less than kSendThresholdPercent % of the
+ // last report. Send a REMB asap.
+ last_remb_time_ms_ = now_ms - kRembSendIntervalMs;
+ }
+ }
+ bitrate_bps_ = bitrate_bps;
+
+ if (now_ms - last_remb_time_ms_ < kRembSendIntervalMs) {
+ return;
+ }
+ // NOTE: Updated if we intend to send the data; we might not have
+ // a module to actually send it.
+ last_remb_time_ms_ = now_ms;
+ last_send_bitrate_bps_ = bitrate_bps;
+ }
+ SendRemb(bitrate_bps, ssrcs);
+}
+
+bool PacketRouter::SendRemb(uint32_t bitrate_bps,
+ const std::vector<uint32_t>& ssrcs) {
+ rtc::CritScope lock(&modules_crit_);
+ // TODO(nisse): Check REMB status of the modules? Or add a loop,
+ // similar to SendTransportFeedback below?
+ RtpRtcp* remb_module;
+ if (!rtp_send_modules_.empty())
+ remb_module = rtp_send_modules_.front();
+ else if (!rtp_receive_modules_.empty())
+ remb_module = rtp_receive_modules_.front();
+ else
+ return false;
+ remb_module->SetREMBData(bitrate_bps, ssrcs);
+ return true;
+}
+
+bool PacketRouter::SendTransportFeedback(rtcp::TransportFeedback* packet) {
RTC_DCHECK(pacer_thread_checker_.CalledOnValidThread());
rtc::CritScope cs(&modules_crit_);
// Prefer send modules.

Powered by Google App Engine
This is Rietveld 408576698