Delete VieRemb class, move functionality to PacketRouter.

webrtc/video_receive_stream.h

 /*
  *  Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 114 matching lines @@
       // See RtcpMode for description.
       RtcpMode rtcp_mode = RtcpMode::kCompound;
 
       // Extended RTCP settings.
       struct RtcpXr {
         // True if RTCP Receiver Reference Time Report Block extension
         // (RFC 3611) should be enabled.
         bool receiver_reference_time_report = false;
       } rtcp_xr;
 
+      // TODO(nisse): This remb setting is currently set but never
+      // applied. REMB logic is now the responsibility of
+      // PacketRouter, and it will generate REMB feedback if
+      // OnReceiveBitrateChanged is used, which depends on how the
+      // estimators belonging to the ReceiveSideCongestionController
+      // are configured. Decide if this setting should be deleted, and
+      // if it needs to be replaced by a setting in PacketRouter to
+      // disable REMB feedback.

[stefan-webrtc, 2017/04/11 09:28:36]

This would be important if there are no other ways for a user to disable REMB.
Can it be done by simply not negotiating abs-send-time or toffset header
extensions?

[nisse-webrtc, 2017/04/11 10:57:41]

As far as I understand, if there are no abs-send-time or toffset header
extensions, no REMB packets will be sent.

+
       // See draft-alvestrand-rmcat-remb for information.
       bool remb = false;
 
       // See draft-holmer-rmcat-transport-wide-cc-extensions for details.
       bool transport_cc = false;
 
       // See NackConfig for description.
       NackConfig nack;
 
       // See UlpfecConfig for description.
@@ skipping 64 matching lines @@
     EnableEncodedFrameRecording(rtc::kInvalidPlatformFileValue, 0);
   }
 
  protected:
   virtual ~VideoReceiveStream() {}
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_VIDEO_RECEIVE_STREAM_H_