Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1721)

Unified Diff: webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h

Issue 2789233005: Move BWE period calculation from ProbingIntervalEstimator to AimdRateControl. (Closed)
Patch Set: Nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h
diff --git a/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h b/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h
index 5a0a34584f7520c60ce4d4797ae33b5595d9d3af..6aa2338e004d25f8638f90814e319ba79f9ba5b7 100644
--- a/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h
+++ b/webrtc/modules/remote_bitrate_estimator/aimd_rate_control.h
@@ -24,7 +24,7 @@ namespace webrtc {
class AimdRateControl {
public:
AimdRateControl();
- virtual ~AimdRateControl();
+ ~AimdRateControl();
// Returns true if there is a valid estimate of the incoming bitrate, false
// otherwise.
@@ -43,11 +43,10 @@ class AimdRateControl {
uint32_t Update(const RateControlInput* input, int64_t now_ms);
void SetEstimate(int bitrate_bps, int64_t now_ms);
- // Returns the increase rate which is used when used bandwidth is near the
- // maximal available bandwidth.
- virtual int GetNearMaxIncreaseRateBps() const;
-
- virtual rtc::Optional<int> GetLastBitrateDecreaseBps() const;
+ // Returns the increase rate when used bandwidth is near the link capacity.
+ int GetNearMaxIncreaseRateBps() const;
+ // Returns the expected time between overuse signals (assuming steady state).
+ int GetExpectedBandwidthPeriodMs() const;
private:
// Update the target bitrate according based on, among other things,

Powered by Google App Engine
This is Rietveld 408576698