Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.cc

Issue 2789233005: Move BWE period calculation from ProbingIntervalEstimator to AimdRateControl. (Closed)
Patch Set: Nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 trendline_estimator_(), 153 trendline_estimator_(),
154 detector_(), 154 detector_(),
155 receiver_incoming_bitrate_(), 155 receiver_incoming_bitrate_(),
156 last_update_ms_(-1), 156 last_update_ms_(-1),
157 last_seen_packet_ms_(-1), 157 last_seen_packet_ms_(-1),
158 uma_recorded_(false), 158 uma_recorded_(false),
159 probe_bitrate_estimator_(event_log), 159 probe_bitrate_estimator_(event_log),
160 trendline_window_size_(kDefaultTrendlineWindowSize), 160 trendline_window_size_(kDefaultTrendlineWindowSize),
161 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff), 161 trendline_smoothing_coeff_(kDefaultTrendlineSmoothingCoeff),
162 trendline_threshold_gain_(kDefaultTrendlineThresholdGain), 162 trendline_threshold_gain_(kDefaultTrendlineThresholdGain),
163 probing_interval_estimator_(&rate_control_),
164 consecutive_delayed_feedbacks_(0), 163 consecutive_delayed_feedbacks_(0),
165 last_logged_bitrate_(0), 164 last_logged_bitrate_(0),
166 last_logged_state_(BandwidthUsage::kBwNormal) { 165 last_logged_state_(BandwidthUsage::kBwNormal) {
167 LOG(LS_INFO) << "Using Trendline filter for delay change estimation."; 166 LOG(LS_INFO) << "Using Trendline filter for delay change estimation.";
168 167
169 network_thread_.DetachFromThread(); 168 network_thread_.DetachFromThread();
170 } 169 }
171 170
172 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector( 171 DelayBasedBwe::Result DelayBasedBwe::IncomingPacketFeedbackVector(
173 const std::vector<PacketFeedback>& packet_feedback_vector) { 172 const std::vector<PacketFeedback>& packet_feedback_vector) {
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
356 LOG(LS_WARNING) << "BWE Setting start bitrate to: " << start_bitrate_bps; 355 LOG(LS_WARNING) << "BWE Setting start bitrate to: " << start_bitrate_bps;
357 rate_control_.SetStartBitrate(start_bitrate_bps); 356 rate_control_.SetStartBitrate(start_bitrate_bps);
358 } 357 }
359 358
360 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) { 359 void DelayBasedBwe::SetMinBitrate(int min_bitrate_bps) {
361 // Called from both the configuration thread and the network thread. Shouldn't 360 // Called from both the configuration thread and the network thread. Shouldn't
362 // be called from the network thread in the future. 361 // be called from the network thread in the future.
363 rate_control_.SetMinBitrate(min_bitrate_bps); 362 rate_control_.SetMinBitrate(min_bitrate_bps);
364 } 363 }
365 364
366 int64_t DelayBasedBwe::GetProbingIntervalMs() const { 365 int64_t DelayBasedBwe::GetExpectedBwePeriodMs() const {
367 return probing_interval_estimator_.GetIntervalMs(); 366 return rate_control_.GetExpectedBandwidthPeriodMs();
368 } 367 }
369 } // namespace webrtc 368 } // namespace webrtc
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698